-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raw-rs: Flip and rotate image based on camera orientation #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
elbertronnie
commented
Sep 2, 2024
•
edited
Loading
edited
- Add Orientation Tag
- Transform image based on camera orientation
elbertronnie
force-pushed
the
add-flip-and-rotation-to-raw-rs
branch
from
September 3, 2024 22:33
e1df57c
to
e7afd90
Compare
For performance, it would be good to originally write to the image array with the transform, instead of the performance impact of swapping the pixel positions. That way the array doesn't need to be traversed another time. Is that feasible? |
Keavon
force-pushed
the
add-flip-and-rotation-to-raw-rs
branch
from
September 5, 2024 21:33
a079ff2
to
b4efc44
Compare
I'll merge this as-is so you can work on the pipeline architectural changes we discussed in our design meeting. |
Keavon
changed the title
Raw-rs: flip and rotate image based on camera orientation
Raw-rs: Flip and rotate image based on camera orientation
Sep 5, 2024
Keavon
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.