Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw-rs: Flip and rotate image based on camera orientation #1954

Merged
merged 6 commits into from
Sep 5, 2024

Conversation

elbertronnie
Copy link
Collaborator

@elbertronnie elbertronnie commented Sep 2, 2024

  • Add Orientation Tag
  • Transform image based on camera orientation

@Keavon
Copy link
Member

Keavon commented Sep 3, 2024

For performance, it would be good to originally write to the image array with the transform, instead of the performance impact of swapping the pixel positions. That way the array doesn't need to be traversed another time. Is that feasible?

@Keavon Keavon force-pushed the add-flip-and-rotation-to-raw-rs branch from a079ff2 to b4efc44 Compare September 5, 2024 21:33
@Keavon
Copy link
Member

Keavon commented Sep 5, 2024

I'll merge this as-is so you can work on the pipeline architectural changes we discussed in our design meeting.

@Keavon Keavon changed the title Raw-rs: flip and rotate image based on camera orientation Raw-rs: Flip and rotate image based on camera orientation Sep 5, 2024
@Keavon Keavon enabled auto-merge (squash) September 5, 2024 21:34
@Keavon Keavon merged commit d9ae01b into master Sep 5, 2024
4 checks passed
@Keavon Keavon deleted the add-flip-and-rotation-to-raw-rs branch September 5, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants