-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pen and Path tool modes to avoid showing all handles #2264
Merged
+342
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
!build |
|
Marking as draft until the feedback I gave in the screencast sent on Discord is resolved. |
Changes after first review -
|
!build |
|
!build |
|
Keavon
approved these changes
Feb 12, 2025
Another issue: in the Pen tool, when not drawing, all handles are shown regardless of mode. |
will fix this asap in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objective was to provide 3 (2 in case of pen tool) modes for the viewer that changes how the handles are shown of the selected anchors. The specific requirements and intended behaviour is well written in the issue which this closes #2261.
The approach is summarised below -
overlay_mode_type
in options of both tools which can be modified by the radio buttons in the tool options layout.Overlays
tool message.path_overlays
is made more modular by giving another argument, which specifies whether all handles, specific handles, frontier handles, or no handles to be drawn.get_selected_segments
is for getting the vector of segmentIds of all segments which are associated with selected elements, which is used specifically for implementing mode 2 and 3.overlay_bezier_handles
utility function is created to avoid repetition of code.