Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement abyss defense objective #2422

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

longfruit
Copy link
Contributor

Description

  • Fix bugs causing abyss chambers to become skipped.
    • One was caused by duplicate finishDungeon() calls from completing WorldChallenge and from checking mob kill count.
    • The other was by TowerResult's incomplete checking of next available tower level.
  • Record tower stars only on challenge's successful completion
  • On tower challenge timeout, fail the challenge and kick player from dungeon
  • Despawn mobs on challenge timeout
    • Also fix RefreshGroup on challenge failure. RefreshGroup gets called by the challenge-fail trigger, but this trigger used to be deregistered when it shouldn't.
  • Implement abyss defense objective
    • idk how the gadget's HP is supposed to scale so hardcoding it to use level 11's GROW_CURVE_HP_ENVIRONMENT for now.
  • Fix open states set by client with value 0. This is a valid value and must be recorded.
    • This fixes the repeated abyss intro scene.
  • Handle AutoMonsterTide calls where fewer mob config IDs are given than the tide's total mob count.
    • When mob IDs run out, reuse the last one to spawn in additional mobs.
  • Properly handle ActiveChallenge's timeLimitOrGroupId.
    • In second half stages, use this as time limit only when one already exists from the first half.

Previews

Before After
Abyss 11-1 gif
Abyss 12 gif
Challenge fail gif gif

Issues fixed by this PR

#2420

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

@KingRainbow44 KingRainbow44 linked an issue Nov 3, 2023 that may be closed by this pull request
@KingRainbow44 KingRainbow44 merged commit 24874e7 into Grasscutters:development Nov 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spiral Abyss[Bug]
2 participants