Close QueryValidation popover on outside click #21347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisoelkers
approved these changes
Jan 23, 2025
dennisoelkers
added a commit
that referenced
this pull request
Jan 24, 2025
This reverts commit 80cdf4d. The PR is breaking parameter support, because declaring a parameter from the popover will break on the first click in the parameter declaration modal.
9 tasks
dennisoelkers
added a commit
that referenced
this pull request
Jan 24, 2025
dennisoelkers
added a commit
that referenced
this pull request
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
onChangecallback to theQueryValidationpopover. That will help maintain to close it on outside clickMotivation and Context
fix: #20468
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
/nocl