Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add RUSTUP_WINDOWS_PATH_ADD_BIN env #3969

Merged
merged 1 commit into from
May 17, 2024
Merged

build: add RUSTUP_WINDOWS_PATH_ADD_BIN env #3969

merged 1 commit into from
May 17, 2024

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented May 17, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Sets RUSTUP_WINDOWS_PATH_ADD_BIN to 1 to fix the release action, according to nextest-rs/nextest#1493

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@evenyag evenyag force-pushed the ci/windows-nextest branch from 36d8c2a to 01c16f5 Compare May 17, 2024 05:16
@evenyag evenyag changed the title ci: add RUSTUP_WINDOWS_PATH_ADD_BIN env to fix release issue build: add RUSTUP_WINDOWS_PATH_ADD_BIN env May 17, 2024
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 17, 2024
@evenyag evenyag marked this pull request as ready for review May 17, 2024 05:18
@evenyag evenyag requested a review from a team as a code owner May 17, 2024 05:18
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.36%. Comparing base (ca409a7) to head (01c16f5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3969      +/-   ##
==========================================
- Coverage   85.37%   85.36%   -0.02%     
==========================================
  Files         978      978              
  Lines      168276   168276              
==========================================
- Hits       143661   143641      -20     
- Misses      24615    24635      +20     

@WenyXu WenyXu added this pull request to the merge queue May 17, 2024
@WenyXu WenyXu mentioned this pull request May 17, 2024
13 tasks
Merged via the queue into main with commit e372e25 May 17, 2024
33 of 40 checks passed
@WenyXu WenyXu deleted the ci/windows-nextest branch May 17, 2024 06:17
WenyXu pushed a commit to WenyXu/greptimedb that referenced this pull request May 17, 2024
WenyXu pushed a commit to WenyXu/greptimedb that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants