This repository has been archived by the owner on Aug 22, 2023. It is now read-only.
PHPORM-63 Remove unused public property Query\Builder::$paginating
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
reviewed
Jul 19, 2023
| /** | ||
| * @inheritdoc | ||
| */ | ||
| public function forPage($page, $perPage = 15) |
There was a problem hiding this comment.
The commit message would benefit from noting that this is being removed as well.
Does the base class' forPage() method do the same thing?
There was a problem hiding this comment.
Yes, the parent method is exactly the same, except for the $paginating property. So removing the method overload doesn't change anything.
…$not` (#13) `Query\Builder::whereNot` was simply ignoring the "not" and breaking the built query.
jmikola
approved these changes
Jul 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPORM-63
Query\Builder::$paginatingis initialized byQuery\Builder::forPagebut never used.Introduced by mongodb/laravel-mongodb@9603949 it was never removed when it stopped being used in mongodb/laravel-mongodb@a8918ac