Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

traits: Add refresh_cpu_frequency and refresh_cpu_all #1055

Merged

Conversation

patrickelectric
Copy link
Contributor

No description provided.

src/traits.rs Outdated
/// let mut s = System::new_all();
/// s.refresh_cpu_all();
/// ```
fn refresh_cpu_all(&mut self) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should rename the existing refresh_cpu into refresh_cpu_usage and rename this one refresh_cpu. What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patrickelectric
Copy link
Contributor Author

@GuillaumeGomez everything should be fixed now.

@GuillaumeGomez
Copy link
Owner

I used git grep and found a few occurrences where refresh_cpu should have been refresh_cpu_usage:

c_interface.rs:69:            system.refresh_cpu();
freebsd/system.rs:121:            self.refresh_cpu();
lib.rs:293:            s.refresh_cpu();
lib.rs:447:            s.refresh_cpu();
lib.rs:490:        s.refresh_cpu();
traits.rs:749:        self.refresh_cpu();

@patrickelectric
Copy link
Contributor Author

ping @GuillaumeGomez

@GuillaumeGomez
Copy link
Owner

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit ffd95c1 into GuillaumeGomez:master Sep 9, 2023
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants