Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: batch support #72

Merged
merged 4 commits into from
Dec 20, 2022
Merged

feature: batch support #72

merged 4 commits into from
Dec 20, 2022

Conversation

H4ad
Copy link
Owner

@H4ad H4ad commented Dec 20, 2022

Closes #20
Closes #21
Closes #71

Description of change

In this PR, I did:

  • Fix wrong behavior with responses of adapters not being validated to check if status was successful.
  • Simplify the code for current adapters and new ones by having now AWSSimpleAdapter abstract class.
  • Added support for batch mode for SQS and DynamoDB.

Pull-Request Checklist

  • Code is up-to-date with the main branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Added documentation inside www/docs/main folder.
  • Included new files inside index.doc.ts.
  • The new commits follow conventions outlined in the conventional commit spec

@H4ad H4ad self-assigned this Dec 20, 2022
@H4ad H4ad added bug Something isn't working enhancement New feature or request labels Dec 20, 2022
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #72 (6edb996) into main (8333dcf) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
- Coverage   99.68%   99.68%   -0.01%     
==========================================
  Files          59       60       +1     
  Lines        1284     1275       -9     
  Branches      284      292       +8     
==========================================
- Hits         1280     1271       -9     
  Misses          4        4              
Impacted Files Coverage Δ
...ameworks/body-parser/base-body-parser.framework.ts 100.00% <ø> (ø)
src/adapters/aws/base/aws-simple-adapter.ts 100.00% <100.00%> (ø)
src/adapters/aws/dynamodb.adapter.ts 100.00% <100.00%> (ø)
src/adapters/aws/event-bridge.adapter.ts 100.00% <100.00%> (ø)
src/adapters/aws/s3.adapter.ts 100.00% <100.00%> (ø)
src/adapters/aws/sns.adapter.ts 100.00% <100.00%> (ø)
src/adapters/aws/sqs.adapter.ts 100.00% <100.00%> (ø)
src/handlers/firebase/http-firebase.handler.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@H4ad H4ad merged commit 7ab7087 into main Dec 20, 2022
@H4ad H4ad deleted the feature/batch-support branch December 20, 2022 15:12
@github-actions
Copy link

🎉 This PR is included in version 2.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request released
Projects
None yet
1 participant