Add H5Tdecode2, rename and deprecate H5Tdecode #5213
+269
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjala
added
Merge - Develop Only
mattjala
requested review from
jhendersonHDF,
byrnHDF,
derobins,
brtnfld,
epourmal,
lrknox,
fortnern,
qkoziol,
vchoi-hdfgroup,
bmribler and
glennsong09
as code owners
qkoziol
reviewed
Jan 8, 2025
qkoziol
requested changes
Jan 8, 2025
bmribler
reviewed
Jan 8, 2025
derobins
added
Component - C++
bmribler
previously approved these changes
Jan 13, 2025
jhendersonHDF
previously approved these changes
Jan 14, 2025
qkoziol
previously approved these changes
Jan 14, 2025
brtnfld
reviewed
Jan 14, 2025
brtnfld
reviewed
Jan 14, 2025
brtnfld
requested changes
Jan 14, 2025
lrknox
requested changes
Jan 15, 2025
src/H5vers.txt
Outdated
| @@ -86,6 +86,7 @@ FUNCTION: H5Tarray_create; ; v14, v18 | |||
| FUNCTION: H5Tcommit; ; v10, v18 | |||
| FUNCTION: H5Tget_array_dims; ; v14, v18 | |||
| FUNCTION: H5Topen; ; v10, v18 | |||
| FUNCTION: H5Tdecode; ; v12, v200 | |||
There was a problem hiding this comment.
I find H5Tdecode in the code tag hdf5-1_8_0, but not in tag hdf5-1_6_10, so I think this line should end with ; v18, v200.
I believe that change would also not add lines 151 - 154 in H5version.h.
There was a problem hiding this comment.
That's strange. I can't find it in 1.6 either, but the reference manual lists it as since 1.2. I'll update both of these to reflect a 1.8 addition.
lrknox
previously approved these changes
Jan 15, 2025
Make buf_size an optional a parameter
Make buf_size optional
test optional parameter
brtnfld
approved these changes
Jan 23, 2025
lrknox
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When provided malformed or too-small buffers, H5Tdecode() could crash due to walking off the end of the buffer. The new buffer size parameter allows this to be reliably avoided.
Resolves #4661