Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Autotools support #5241

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Remove Autotools support #5241

wants to merge 11 commits into from

Conversation

byrnHDF
Copy link
Contributor

@byrnHDF byrnHDF commented Jan 15, 2025

No description provided.

@byrnHDF byrnHDF added Priority - 0. Blocker ⛔ This MUST be merged for the release to happen Component - C Library Core C library issues (usually in the src directory) Component - Tools Command-line tools like h5dump, includes high-level tools Component - High-Level Library Code in the hl directory Component - Documentation Doxygen, markdown, etc. Component - Java Java wrappers Component - Fortran Fortran wrappers Component - C++ C++ wrappers Component - Parallel Parallel HDF5 (NOT thread-safety) Component - Testing Code in test or testpar directories, GitHub workflows Component - Build CMake, Autotools Type - Deprecation / Removal We strive for backward-compatibility, so it's worth noting this separately Component - Misc Anything else (CODEOWNERS, etc.) labels Jan 15, 2025
@byrnHDF byrnHDF self-assigned this Jan 15, 2025
hyoklee
hyoklee previously approved these changes Jan 15, 2025
View reviewed changes
@derobins derobins changed the title Develop remove at Remove Autotools support Jan 16, 2025
hyoklee
hyoklee previously approved these changes Jan 17, 2025
View reviewed changes
derobins
derobins reviewed Jan 21, 2025
View reviewed changes
.gitattributes Outdated
HDF5Examples/C/H5VDS/h5_vds-percival-unlim-maxmin.c -text
HDF5Examples/C/H5VDS/h5_vds-percival-unlim.c -text
HDF5Examples/C/H5VDS/h5_vds-percival.c -text
HDF5Examples/C/H5VDS/h5_vds-simpleIO.c -text
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need these lines for .c and .txt files? Can't git tell that those files are text?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered but just went ahead and tried to fix what was there.

derobins
derobins reviewed Jan 21, 2025
View reviewed changes
.gitattributes Outdated
java/test/testfiles/JUnit-TestH5Tbasic.txt -text
java/test/testfiles/JUnit-TestH5Tparams.txt -text
java/test/testfiles/JUnit-TestUnit.txt -text
java/test/testfiles/JUnit-TestH5Z.txt -text
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And why do HDF5 files have the -text attribute (below) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because they were there before - I guess they were never reviewed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@derobins
Copy link
Member

I'll go ahead and approve. We can fix stragglers in future PRs.

derobins
derobins previously approved these changes Jan 21, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyoklee hyoklee hyoklee left review comments

@derobins derobins derobins left review comments

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

@epourmal epourmal Awaiting requested review from epourmal epourmal is a code owner

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@byrnHDF byrnHDF

Labels
Component - Build CMake, Autotools Component - C Library Core C library issues (usually in the src directory) Component - C++ C++ wrappers Component - Documentation Doxygen, markdown, etc. Component - Fortran Fortran wrappers Component - High-Level Library Code in the hl directory Component - Java Java wrappers Component - Misc Anything else (CODEOWNERS, etc.) Component - Parallel Parallel HDF5 (NOT thread-safety) Component - Testing Code in test or testpar directories, GitHub workflows Component - Tools Command-line tools like h5dump, includes high-level tools Priority - 0. Blocker ⛔ This MUST be merged for the release to happen Type - Deprecation / Removal We strive for backward-compatibility, so it's worth noting this separately
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@byrnHDF @derobins @hyoklee