Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for a couple of trivial warnings #676

Merged
merged 35 commits into from
May 24, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
ba9deae
Committing clang-format changes
github-actions[bot] Mar 19, 2021
00f9750
Merge remote-tracking branch 'canonical/develop' into develop
Mar 21, 2021
e997283
Merge remote-tracking branch 'canonical/develop' into develop
Mar 22, 2021
3eac585
Merge remote-tracking branch 'canonical/develop' into develop
Mar 23, 2021
71643b7
Merge remote-tracking branch 'canonical/develop' into develop
Mar 24, 2021
d242911
Merge remote-tracking branch 'canonical/develop' into develop
Mar 24, 2021
bc70f95
Merge remote-tracking branch 'canonical/develop' into develop
Mar 26, 2021
3d7ad8e
Merge remote-tracking branch 'canonical/develop' into develop
Mar 26, 2021
aeb16b7
Merge branch 'develop' of https://github.com/derobins/hdf5 into develop
Mar 26, 2021
765cb5b
Merge remote-tracking branch 'canonical/develop' into develop
Mar 27, 2021
18401fc
Merge remote-tracking branch 'canonical/develop' into develop
Mar 29, 2021
222242c
Merge branch 'develop' of https://github.com/derobins/hdf5 into develop
Mar 29, 2021
8d0cafa
Merge remote-tracking branch 'canonical/develop' into develop
Mar 30, 2021
d3694d1
Merge remote-tracking branch 'canonical/develop' into develop
Apr 2, 2021
1c7bcc2
Merge remote-tracking branch 'canonical/develop' into develop
Apr 15, 2021
70551e3
Merge remote-tracking branch 'canonical/develop' into develop
Apr 16, 2021
2dfc7db
Merge remote-tracking branch 'canonical/develop' into develop
Apr 20, 2021
71d2fbf
Merge remote-tracking branch 'canonical/develop' into develop
Apr 21, 2021
c8925f8
Merge remote-tracking branch 'canonical/develop' into develop
Apr 22, 2021
dd3e970
Merge branch 'develop' of https://github.com/derobins/hdf5 into develop
Apr 22, 2021
bb61990
Merge remote-tracking branch 'canonical/develop' into develop
Apr 23, 2021
2c2b368
Merge remote-tracking branch 'canonical/develop' into develop
Apr 25, 2021
be2ada6
Merge remote-tracking branch 'canonical/develop' into develop
Apr 27, 2021
439f3a8
Merge remote-tracking branch 'canonical/develop' into develop
Apr 28, 2021
649aa9b
Merge remote-tracking branch 'canonical/develop' into develop
Apr 29, 2021
3fa627f
Merge remote-tracking branch 'canonical/develop' into develop
Apr 29, 2021
0df36ec
Merge remote-tracking branch 'canonical/develop' into develop
May 3, 2021
d65c841
Merge remote-tracking branch 'canonical/develop' into develop
May 6, 2021
fc7eb21
Merge branch 'develop' of https://github.com/derobins/hdf5 into develop
May 6, 2021
130d491
Merge remote-tracking branch 'canonical/develop' into develop
May 8, 2021
544b320
Merge remote-tracking branch 'canonical/develop' into develop
May 15, 2021
bb66bb1
Merge remote-tracking branch 'canonical/develop' into develop
May 18, 2021
0c87055
Merge remote-tracking branch 'canonical/develop' into develop
May 20, 2021
33ca480
Merge remote-tracking branch 'canonical/develop' into develop
May 21, 2021
8a0aba4
Trivial warning fixes:
May 22, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/H5Tbit.c
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,6 @@ H5T__bit_get_d(uint8_t *buf, size_t offset, size_t size)
/* Set return value */
ret_value = val;

done:
FUNC_LEAVE_NOAPI(ret_value)
} /* end H5T__bit_get_d() */

Expand Down
6 changes: 3 additions & 3 deletions tools/test/h5jam/h5jamgentest.c
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ gent_ub(const char *filename, size_t ub_size, size_t ub_fill)
for (u = 0; u < ub_fill; u++)
*bp++ = pattern[u % 10];

HDwrite(fd, buf, ub_size);
(void)HDwrite(fd, buf, ub_size);

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generators generally ignore errors. They should probably be rewritten to not do that, but in the meantime it's okay to ignore the warning about not using the return value from write().

HDclose(fd);
}
Expand All @@ -301,7 +301,7 @@ create_textfile(const char *name, size_t size)
for (i = 0; i < size; i++)
*bp++ = pattern[i % 10];

HDwrite(fd, buf, size);
(void)HDwrite(fd, buf, size);

HDfree(buf);

Expand Down Expand Up @@ -329,7 +329,7 @@ create_binfile(char *name, off_t size)
for (i = 0; i < size; i++)
*bp++ = (char)i & 0xff;

HDwrite(fd, buf, size);
(void)HDwrite(fd, buf, size);

HDclose(fd);
}
Expand Down
2 changes: 1 addition & 1 deletion tools/test/h5stat/h5stat_gentest.c
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,7 @@ gen_err_refcount(const char *fname)
attribute message */
if ((fd = HDopen(fname, O_RDWR, 0633)) >= 0) {
HDlseek(fd, 4520 + 24, SEEK_SET);
HDwrite(fd, &val, 2);
(void)HDwrite(fd, &val, 2);
HDclose(fd);
}

Expand Down