Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phase-Shifted Gates Unitary Correction #601

Merged
merged 4 commits into from
Nov 7, 2024
Merged

Phase-Shifted Gates Unitary Correction #601

merged 4 commits into from
Nov 7, 2024

Conversation

mlodi-hqs
Copy link
Contributor

Now they should correctly handle the effect of the additional controlling qubit, expanding from the paper https://arxiv.org/pdf/1908.06101

dberthault
dberthault requested changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@dberthault dberthault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should update the matrix in the qoqo/src/operations/tree_qubit_gategate_operations documentation also

@mlodi-hqs mlodi-hqs added this pull request to the merge queue Nov 7, 2024
Merged via the queue into HQSquantumsimulations:main with commit 3418134 Nov 7, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dberthault dberthault dberthault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlodi-hqs @dberthault