Adapt and modify tests

[vddesai1871]

Fixes #296

Checklist

• My branch is up-to-date with upstream/develop branch.
• Everything works and tested for Python 3.5.2 and above.

Description

Adapts the tests in test_app.py to recent changes.

Test Logs

(h) vishal@vishal:~/oss/hydrus$ pytest hydrus/tests/
============================================================ test session starts ============================================================
platform linux -- Python 3.5.2, pytest-3.4.2, py-1.5.2, pluggy-0.6.0
rootdir: /home/vishal/oss/hydrus, inifile:
collected 51 items                                                                                                                          

hydrus/tests/test_app.py ................                                                                                             [ 31%]
hydrus/tests/test_auth.py ..........                                                                                                  [ 50%]
hydrus/tests/test_crud.py ............                                                                                                [ 74%]
hydrus/tests/test_doc_writer.py ....                                                                                                  [ 82%]
hydrus/tests/test_parser.py .........                                                                                                 [100%]

========================================================= 51 passed in 3.88 seconds =========================================================
(h) vishal@vishal:~/oss/hydrus$ git add hydrus/samples/doc_writer_sample.py

Changes log

Debugs various errors mentioned in #296

Added

• Feature 1
• Feature 2

Changed

• Change 1
• Change 2

Fixed

• Bug 1

Removed

• Deprecated feature 1

[chrizandr]

It would be good if you could also try and run this test for another API documentation, other than the dummy one created in the sample. Maybe try for the flock-demo documentation and see if all tests pass.

[vddesai1871]

Maybe try for the flock-demo documentation and see if all tests pass.

2 tests are failing because I am assuming if an endpoint class has POST or DELETE or GET method it must have a PUT method, so I am using put(directly without checking if class supports PUT operation) to add a new object before testing for GET, POST and DELETE.
(Area class in flock-demo is an endpoint class and doesn't have PUT method defined but has POST defined)
This piece of code is being used for testing endpoint class POST requests

                    if "POST" in class_methods:
                        dummy_object = gen_dummy_object(class_.title, self.doc)
                        put_response = self.client.put(
                            endpoints[class_name], data=json.dumps(dummy_object)
                        )
                        assert put_response.status_code == 201
                        post_response = self.client.post(
                            endpoints[class_name], data=json.dumps(dummy_object))
                        assert post_response.status_code == 200

[Mec-iS]

it is not mandatory for any endpoint to have other methods beside the ones it declares in the doc. So the test should be fixed to test only the methods allowed by the endpoint, the others should return Method Not Allowed.

[Mec-iS]

in the context of a unit test, every test case should be absolutely independent from other tests. So in this case, and any similar cases, we should insert the item using the ORM and then test only the GET:

def test_get_method(self):
     # test setup
     Item.create(...)
     
     # assertion
     assert requests.get(...).status_code == 200

Even better: the item creation should be in the class' setUp method (check unittest.TestCase.setUp in standard library) and reused by all the tests in the class.

[vddesai1871]

It would be good if you could also try and run this test for another API documentation, other than the dummy one created in the sample. Maybe try for the flock-demo documentation and see if all tests pass.

Yes now tests are passing for flock-demo doc. Thanks!

[xadahiya]

@vddesai1871 Looks good! Could you please replace the """ with simple comments.

[xadahiya]

Also, can you fix this deprecation warning?

[vddesai1871]

Also, can you fix this deprecation warning?

I don't think I can do anything about this. It is related to pyyaml's compatibility with pythin 3.7 they are woking on it