-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #608
base: develop
Are you sure you want to change the base?
Update README.md #608
Conversation
Hi maintainers , i am new to open source contribution , requested to merge my PR |
|
please try to run the server in local and see if there is something useful you can add to the document, at this point there are only minor changes in this PR. |
Ok |
Hi @Mec-iS i have done some more changes in the doc please review it. Requested to merge the PR. |
Hi @Mec-iS why has this test failed ! can you explain me . |
you can see the full Travis log at https://app.travis-ci.com/github/HTTP-APIs/hydrus/jobs/557575062 nice try but it is still minor changes. Conventions:
|
can u explain me this error i am not able to figure it out , i have just changed / added new reference |
Hi @Mec-iS i have updated the Doc/wiki/images they were not clear and the updated version is better , requested to merge this pr or suggest some more changes |
this is still not implemented. Also you have to rebase this PR to the develop branch |
ok ill look into it |
now can you verify is my branch up to date ! , i will correct |
hi @Mec-iS i have done some more contribution , i have one doubt when we run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hydrus
is small-case- I don't think we need images in hydrus repo
- You have converted the docstrings in python files to comments. Docstrings and comments are not the same thing. You can see the memo in the docstrings easily by running "help" function. Docstrings are helpful to explain a detailed description of function, class or module
issue number #607
Checklist
Current behaviour
less reference and some grammatical error in readme file
New expected behaviour
fixed issue
Change logs
can see my commit