isa-w1-Browsers #47
isa-w1-Browsers #47
Conversation
There was a problem hiding this comment.
Great work @isaerenie 👏 Code already looks good and I see that you've put in quite some effort for this, nice job! Some of the exercises are not working completely as expected yet, please see if you can fix this 💪
| liElement.style.border = '1px solid black'; | ||
| liElement.style.margin = '10px'; | ||
| liElement.style.padding = '10px'; | ||
| liElement.style.listStyle = 'none'; |
There was a problem hiding this comment.
I would suggest to not set these styles via JavaScript, you can just use the CSS file for this 🙂
| imgElement.style.width = '100px'; | ||
| imgElement.style.height = '150px'; |
There was a problem hiding this comment.
The same for these styles 😄 You can add them in the CSS file.
There was a problem hiding this comment.
Almost! I see the design does not completely match with the expected outcome 😄 Can you see if you can fix this? 💪
There was a problem hiding this comment.
This is the expected outcome: https://github.com/HackYourAssignment/Assignments-cohort51/blob/main/assets/catwalk.gif
| } | ||
|
|
||
| updateTime(); | ||
| setInterval(updateTime, 1000); |
There was a problem hiding this comment.
Great code! Works as expected 💪 One tip when it comes to setting intervals, I think it's a good practice to also clear them to avoid memory leaks and performance problems.
By clearing the interval you make sure that it does not run anymore when it is not required.
There was a problem hiding this comment.
I see the cat is walking nicely across the screen but unfortunately it keeps moving in the middle of the screen with the other image 😄 Please see if you can fix this 💪
No description provided.