W2 aziz49 react #15
Open
W2 aziz49 react #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robvk
requested changes
Nov 20, 2024
There was a problem hiding this comment.
Overall seems good but let's add some practice for you:
- Yes, please remove the prep exercises. Is good git practice to see how to do that.
- As we discussed, let's remove zustand here and use the standard react libraries to code this project. That will help cement the core React functionality which is more important to get right
week2/project/ecommerce/src/App.jsx
Outdated
| import ProductDetailPage from "./pages/ProdutcDetailPage"; | ||
|
|
||
| const App = () => { | ||
| const [selectedCategory, setSelectedCategory] = useState(""); |
| import axios from "axios"; | ||
|
|
||
| const ProductDetailPage = () => { | ||
| const { id } = useParams(); |
|
|
||
| if (isLoading) return <p>Loading product...</p>; | ||
| if (error) return <p>{error}</p>; | ||
| if (!product) return <p>Product not found</p>; |
robvk
requested changes
Nov 25, 2024
|
|
||
| return ( | ||
| <div> | ||
| <h1>Product Categories</h1> |
There was a problem hiding this comment.
Formatting is not great here. Remember prettier!
| import ErrorMessage from "./ErrorMessage.jsx"; | ||
| import ProductCard from "./ProductCard.jsx"; | ||
|
|
||
| function CategoryPage() { |
There was a problem hiding this comment.
This component is called CategoryPage but is not in the pages folder.
| import Loader from "./Loader.jsx"; | ||
| import ErrorMessage from "./ErrorMessage.jsx"; | ||
|
|
||
| function ProductDetail() { |
There was a problem hiding this comment.
I think this is a page component too (just like CategoryPage), but then without the Page at the end. Be consistent and clear with these names as when your product gets big naming helps you out a lot.
| function ProductDetail() { | ||
| const { id } = useParams(); | ||
| const [product, setProduct] = useState(null); | ||
| const [loading, setLoading] = useState(false); |
| setLoading(true); | ||
| try { | ||
| const response = await fetch(`https://fakestoreapi.com/products/${id}`); | ||
| if (!response.ok) throw new Error("Failed to fetch product details"); |
There was a problem hiding this comment.
No, that is throwing the error. Where are you handling the error?
| @@ -0,0 +1,5 @@ | |||
| function ErrorMessage({ message }) { | |||
robvk
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should i delete prepex w2 from this brnach?