Tugbanur-React week2 #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaryRichelle
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Great job! 👏👏
I’d like to point out two things:
When starting work, always check out from the main branch. This makes it easier for us to review only the files that were changed during the week.
It would be better to move the API logic into a separate file for cleaner and more organized code.
| } | ||
| /> | ||
| <Route path="/product/:id" element={<ProductDetail />} /> | ||
| </Routes> |
There was a problem hiding this comment.
Nice work
Next time try moving the Routes and Route setup into a separate file or component. This will make the code easier to read and manage, especially if you add more routes in the future.
There was a problem hiding this comment.
Thank you. I will do that in the project. Thanks for your feedback
| import { useEffect, useState } from "react"; | ||
|
|
||
| const ProductDetail = () => { | ||
| const { id } = useParams(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.