W3 aziz react #29
Open
W3 aziz react #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robvk
requested changes
Nov 27, 2024
week1/project/fakeshop/src/App.jsx
Outdated
| const [selectedCategory, setSelectedCategory] = useState(null); // Başlangıçta kategori seçilmemiş | ||
|
|
||
| // Kategori seçildiğinde ürünleri filtrele | ||
| const handleCategoryClick = (category) => { |
There was a problem hiding this comment.
Why do you need this function? It only calls one other function
| <div className="category-list"> | ||
| {categories.map((category, index) => ( | ||
| <button key={index} onClick={() => { | ||
| console.log("Category clicked: ", category); // Tıklanan kategoriyi kontrol edelim |
There was a problem hiding this comment.
Remove console logs from the code when creating a PR
| <FavoritesProvider> | ||
| <Router> | ||
| <NavBar /> | ||
| <Routes> |
|
|
||
| const ProductCard = memo(({ product }) => { | ||
| const { favorites, toggleFavorite } = useFavorites(); | ||
| const isFavorite = favorites.includes(product.id); |
There was a problem hiding this comment.
You are doing this in two places, maybe nicer to have the Favorites context provide this function?
| dispatch({ type: "TOGGLE_FAVORITE", payload: id }); | ||
| }; | ||
|
|
||
| const value = useMemo( |
|
|
||
| const initialState = []; | ||
|
|
||
| const favoritesReducer = (state, action) => { |
There was a problem hiding this comment.
Little over the top to use a reducer here but cool that you are trying it!
|
|
||
| useEffect(() => { | ||
| const fetchFavorites = async () => { | ||
| const fetchedProducts = await Promise.all( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.