Tugbanur-React week1 #8
Conversation
|
Here is the deployed link: Netlify App URL |
| className="product-image" | ||
| /> | ||
| <h4>{product.title}</h4> | ||
| </div> |
There was a problem hiding this comment.
Great work.
It would be good to create a separate Product component and move the code for each product card into it. This will make the code simpler and easier to reuse.
I noticed that when you click on different categories, the app's height changes because the images take time to load. To fix this, try giving the product cards and images a fixed height and width. This will keep everything looking neat and stable, even while the images are loading.
There was a problem hiding this comment.
It didn't fixed images but I will try to find solution to that. Thank you for your feedbacks.
There was a problem hiding this comment.
try searching on the web what is the meaning of fix height in CSS ? you will find a solution.
|
I see there you approved my pull request but can you please Label it too. :) Because somenone from hyf is checking our assignments is it approved or not. They follow from the label. |
| @@ -3,6 +3,8 @@ | |||
| gap: 16px; | |||
| justify-content: center; | |||
| grid-template-columns: repeat(2, 1fr); | |||
| height: fixed; | |||
There was a problem hiding this comment.
There is no such property, value in CSS like height :fixed;
"fixed height" refers to setting a specific, unchanging height for an element. When an element has a fixed height, it will always occupy the exact height specified, regardless of its content or the surrounding layout.
like height:200px;
it will always be 200px tall, even if the content inside the element is less or more than that height.
I have already informed your instructors for the react module about this. we are facing an issue. I will update the label as soon as the issue is resolved |
No description provided.