fady-w3-database #23
fady-w3-database #23
Conversation
| @@ -0,0 +1,149 @@ | |||
|
|
|||
| import mysql from 'mysql2'; | |||
There was a problem hiding this comment.
None of the files from the week1 assignment should be in this pull request, please remove.
| @@ -0,0 +1,19 @@ | |||
| ## What columns violate 1NF? | |||
|
|
|||
| # food_code and food_description violate 1NF coz they store multiple values. | |||
There was a problem hiding this comment.
This is true but there are 2 other columns that violate 1NF. See if you can spot them
There was a problem hiding this comment.
(Oops I meant to say there is 1 other column, not 2)
|
|
||
|
|
There was a problem hiding this comment.
minor stylistic comment: Similar comment to last time - using lots of whitespace can actually make the code harder to read. The standard approach is to not use more than one line of whitespace to separate logical blocks of code, and not to put whitespace between every little thing. Of course this is subjective but this is most likely the type of feedback you would get in a real life code review
| import {createConnection} from './transactions-create-tables.js'; | ||
|
|
||
|
|
||
| async function transferAmount(fromAccount, toAccount, amount) { |
There was a problem hiding this comment.
Nice job making a generic function that can handle a transfer between any two accounts!
| @@ -0,0 +1,19 @@ | |||
| ## What columns violate 1NF? | |||
|
|
|||
| # food_code and food_description violate 1NF coz they store multiple values. | |||
There was a problem hiding this comment.
(Oops I meant to say there is 1 other column, not 2)
| # every non-key attribute depends on the entire primay key 2NF | ||
| # there is no transitive dependencies 3NF | ||
|
|
||
| # member_address column might contain multiple values if a member has more than one address a home and a work address. Storing with comma-separated value would violate 1NF. |
There was a problem hiding this comment.
These are all great ideas and ways to avoid potential 1NF violations if they were to occur. But 1NF also says that all the data in a column should be in the same format. There is 1 column that violates this rule in the original table. Which is it?
| @@ -0,0 +1,149 @@ | |||
|
|
|||
There was a problem hiding this comment.
These files are still present. You can simply delete them as part of your next commit. They will still be present on your other branch so you don't need to worry about losing them
No description provided.