LidiiaStarshynova-w4-Databases #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunchen4
requested changes
Jan 24, 2025
Comment on lines
17
to
31
| const yearAgePopulation = await collection.aggregate([ | ||
| {$match: {Year: year, Age: age}}, | ||
| {$addFields: { | ||
| TotalPopulation: { $add: ["$M", "$F"] }, | ||
| }}, | ||
| { | ||
| $project: { | ||
| Country: 1, | ||
| Year: 1, | ||
| Age: 1, | ||
| M: 1, | ||
| F: 1, | ||
| TotalPopulation: 1, | ||
| },} | ||
| ]).toArray() |
There was a problem hiding this comment.
Need to work: the question asks about the total population of each continent. If you take a look at data you may notice in column Country there are AFRICA, ASIA etc separating from the real countries. Try to use those continent name values in the country column.
Comment on lines
+27
to
+40
| const destinationAccountDoc = await collection.findOne({ account_number: destinationAccount.accountNumber }, | ||
| { session }); | ||
|
|
||
| const maxChangeNumberSource = sourceAccountDoc.account_changes.length > 0 | ||
| ? Math.max(...sourceAccountDoc.account_changes.map(change => change.change_number)) | ||
| : 0; | ||
|
|
||
| const maxChangeNumberDestination = destinationAccountDoc.account_changes.length > 0 | ||
| ? Math.max(...destinationAccountDoc.account_changes.map(change => change.change_number)) | ||
| : 0; | ||
|
|
||
| if (!sourceAccountDoc || sourceAccountDoc.balance < transferAmount) { | ||
| throw new Error("There is not enough money to execute the operation."); | ||
| } |
There was a problem hiding this comment.
Very good check before doing actual transfer!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.