Rubamansour week4 databases #31
Conversation
RubaMansour
force-pushed
the
Rubamansour-week4-DATABASES
branch
from
5587909 to
6cb6fb9
Compare
RubaMansour
force-pushed
the
Rubamansour-week4-DATABASES
branch
from
6cb6fb9 to
4a2e80f
Compare
There was a problem hiding this comment.
Hi Ruba,
Your assignment looks good to me. There's only one comment that you need to rework.
Please let me know once you finish your rework.
And also pay attention to the changes in your commit. You only need to submit the assignment for the week. Try not to commit irrelevant files and changes.
If you have any questions please let me know. Have a nice weekend!
| const pipeline = [ | ||
| { $match: { Year: year, Age: ageGroup } }, { | ||
| $group: { | ||
| _id: "$Country", | ||
| Year: { $first: "$Year" }, | ||
| Age: { $first: "$Age" }, | ||
| M: { $sum: "$M" }, | ||
| F: { $sum: "$F" } | ||
| } | ||
| }, | ||
|
|
||
| { | ||
| $project: { | ||
| _id: 1, | ||
| Country: "$_id", | ||
| Year: 1, | ||
| Age: 1, | ||
| M: 1, | ||
| F: 1, | ||
| TotalPopulation: { $add: ["$M", "$F"] } } | ||
| }, | ||
| { $sort: { Country: 1 } } | ||
| ]; |
There was a problem hiding this comment.
Need to work: the question asks about the total population of each continent. If you take a look at data you may notice in column Country there are AFRICA, ASIA etc separating from the real countries. Try to use those continent name values in the country column.
And could you please tell me why you use group here?
| } catch (err) { | ||
| console.error('Error:', err); | ||
| return []; |
There was a problem hiding this comment.
Depending on the situation you may decide if you want to return empty result if there's an error. Since this is a business-required functionalities, usually you don't want to return empty result. Instead you want to throw it until some error handlers handle it.
|
|
||
| { | ||
| $addFields: { | ||
| TotalPopulation: { $add: ['$M', '$F'] } // إضافة مجموع السكان |
There was a problem hiding this comment.
suggestion: unless you're working for a company with only people knowing Arabic, it's better to write comments in English :)
| await accountsCollection.updateOne( | ||
| { account_number: fromAccount }, | ||
| { | ||
| $set: { balance: updatedFromBalance }, | ||
| $push: { | ||
| account_changes: { | ||
| change_number: fromChangeNumber, | ||
| amount: -amount, | ||
| changed_date: new Date(), | ||
| remark | ||
| } | ||
| } | ||
| }, | ||
|
|
||
| ); |
There was a problem hiding this comment.
Need to work: you need to add session if you want to include this operation in the transaction. Same as what you did for findOne above.
| await accountsCollection.updateOne( | ||
| { account_number: toAccount }, | ||
| { | ||
| $set: { balance: updatedToBalance }, | ||
| $push: { | ||
| account_changes: { | ||
| change_number: toChangeNumber, | ||
| amount: amount, | ||
| changed_date: new Date(), | ||
| remark | ||
| } | ||
| } | ||
| }, | ||
|
|
||
| ); |
No description provided.