Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to core::array::from_fn once rustc fix has been around long enough #1

Closed
HadrienG2 opened this issue Mar 11, 2023 · 0 comments · Fixed by #3
Closed

Switch back to core::array::from_fn once rustc fix has been around long enough #1

HadrienG2 opened this issue Mar 11, 2023 · 0 comments · Fixed by #3
Labels
enhancement New feature or request

Comments

@HadrienG2
Copy link
Owner

In this crate, I had to reimplement core::array::from_fn because it had bad codegen on then-current rustc releases. However, a fix has landed in nightly and should be making its way to 1.69 eventually: rust-lang/rust#108765 .

This raises the question of when it is appropriate to bump the minimal rustc requirement for good codegen, in a crate where runtime performance is the whole point. For the time being, my custom array::from_fn does not harm much and can stay around, but in a couple of years, once rustc 1.67 and 1.68 are old news, I should consider dropping it.

@HadrienG2 HadrienG2 added the enhancement New feature or request label Mar 11, 2023
HadrienG2 added a commit that referenced this issue Oct 2, 2023
Now that MRSV is 1.70, issue #1 cannot be observed on any supported Rust version.

Fixes #1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant