Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for service definition autocompletion in Annotations from the JMSDiExtraBundle #245

Closed
Spea opened this issue Feb 18, 2014 · 4 comments
Labels

Comments

@Spea
Copy link

Spea commented Feb 18, 2014

It would be nice, to have autocompletion for service definitions in the according attributes for the annotations from them JMSDiExtraBundle (e.g. @Service(id = "..."))

@dewos
Copy link

dewos commented Feb 18, 2014

In @route("/", service="acme.controller.main") too. +1

@nick4fake
Copy link

What about support of some annotation-like defines for symfony annotations to typehint annotations arguments?

There are LOTS of annotations thus support of everything is impossible.

For example, we could write something like:
@IntellijSymfony\Param(service)
in annotation class.

@Haehnchen
Copy link
Owner

i would suggest to implement it more independently. since phpstorm7 we know the annotation references. so external libs/projects should just provide some config files.

btw. JAVA and Intellij have a similar impl (Annotation Processors)

IntellijSymfony\Param -> \Foo\Class\Param

.ide-config-annotations.xml

<annotation class="\Foo\Class\Param">
  <property name="message">Service</property>
</annotation>

or

/**
 * @Annotation
 * @Target("PROPERTY", "METHOD", "CLASS", "ALL")
 */
class NotBlank extends Constraint {

    /**
    * Some attr here? like #Service
    * 
    * @Annotation
    * @Target("PROPERTY", "METHOD", "CLASS", "ALL")
    * 
    */
    public $message;
}

see also:
https://github.com/Haehnchen/idea-php-annotation-plugin

@Haehnchen
Copy link
Owner

implemented; also JMSDiExtraBundle stuff, but i dont thinks that right in this plugin, we are already fine to make it configratable. just see commit size...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants