Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing argument in services.yml doesn't keep track of factory methods #492

Closed
spdionis opened this issue Apr 29, 2015 · 3 comments
Closed
Labels

Comments

@spdionis
Copy link

The missing argument inspection in services definition doesn't understand if the service is created by a factory. Example:

services:
  service:
    class: MyClass
    factory_class: MyClass
    factory_method: factory      
class MyClass
{
    public function __construct($a, $b) {}

    public function factory() {}
}

I believe this was added in last update?

@ruudk
Copy link
Contributor

ruudk commented May 1, 2015

I was just heading to this project to report the bug :)

Great work @Haehnchen, this plugin is a piece of art!

@Haehnchen
Copy link
Owner

👍

@spdionis
Copy link
Author

spdionis commented May 2, 2015

Great, thank you :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants