Minor PS API changes for 10.0.x will break plugin

[neuro159]

com.jetbrains.php.lang.psi.resolve.types.PhpType#add(java.util.Collection<java.lang.String>) is removed.

please use series of com.jetbrains.php.lang.psi.resolve.types.PhpType#add(java.lang.String) calls.

[Haehnchen]

@neuro159 I think com.jetbrains.php.lang.psi.resolve.types.PhpType#add(com.intellij.util.io.StringRef) will also be removed?

Replacement especially for PhpTypeProvider2 would be nice. It's definitely a hack by now to simulate array return types. Is there a way do not break is feature?

fr.adrienbrault.idea.symfony2plugin.doctrine.ObjectRepositoryResultTypeProvider#getBySignature

if(name.equals("findAll") || name.equals("findBy")) {
  method.getType().add(phpClass.getFQN() + "[]");
  return phpNamedElementCollections;
}

[emil-nasso]

Sorry for hijacking this issue. Does anyone know the status of this plugin in phpstorm 10? Will updating completely break it?

[Haehnchen]

PhpStorm 10 itself will work. some tests fail https://travis-ci.org/Haehnchen/idea-php-symfony2-plugin but not critical. but with next release 10.0.x we will get into trouble.

[apfelbox]

@Haehnchen could you please release a hotfix fixing this?

In the new EAP, every (!) single click in a PHP file triggers

16:30:15 NoSuchMethodError: com.jetbrains.php.lang.psi.resolve.types.PhpType.add(Ljava/util/Collection;)Lcom/jetbrains/php/lang/psi/resolve/types/PhpType;

[ByScripts]

@apfelbox I confirm.

[Haehnchen]

... possible tomorrow