Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inspections about using FQCN rather than type name should be disabled on Symfony 2.7 #734

Closed
stof opened this issue May 24, 2016 · 4 comments
Closed

Inspections about using FQCN rather than type name should be disabled on Symfony 2.7 #734

stof opened this issue May 24, 2016 · 4 comments
Labels
fixed

Comments

@stof
Copy link
Contributor

stof commented May 24, 2016

Displaying such warning when the project uses Symfony 2.7 or older is wrong (and annoying as it creates lots of messages I need to ignore, making it harder to spot real warnings)
@stof
Copy link
Contributor Author

stof commented May 24, 2016

OK, not that critical as I can disable the inspection in the PhpStorm settings, but it would still be great that the inspection detects automatically whether it should warn or no.

@Haehnchen
Copy link
Owner

version compare on \Symfony\Component\HttpKernel\Kernel::VERSION also discussed in commit cf47fb7

@stof
Copy link
Contributor Author

stof commented May 25, 2016

Well, I totally agree with @XitasoChris on this. Forcing users to disable the inspections manually based depending on their Symfony version is a bad user experience.

Haehnchen added a commit that referenced this issue May 27, 2016
@Haehnchen
inspection for deprecations should only be available with their corre…
c60e981 
…sponding Symfony versions #734
@Haehnchen
Copy link
Owner

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stof @Haehnchen