Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using a classname as service id in a routing.yml, the symfony2 plugin is mistakenly reporting the method as missing (Symfony 3.3) #940

Closed
MetalArend opened this issue May 30, 2017 · 1 comment
Assignees
Labels

Comments

@MetalArend
Copy link

As of Symfony 3.3, it is possible to use autowiring for services, using the class names of your service as the id of the service. This means that in a routing.yml the class name of a controller can be used to use that controller as a service.

PHPStorm correctly navigates from such a _controller definition in routing.yml to the actual action method without a problem, but it seems the fr.adrienbrault.idea.symfony2plugin.config.yaml.inspection.EventMethodCallInspection inspection cannot detect the action method is already present.

The auto fix on ALT+ENTER also provides the possibility to Create Method, but once you do that, it creates a method that is already present, and PHPStorm complains about the duplicate method.

@Haehnchen Haehnchen added the todo label Jun 3, 2017
@Haehnchen Haehnchen self-assigned this Jun 3, 2017
Haehnchen added a commit that referenced this issue Jun 3, 2017
…istakenly reporting the method as of missing in Symfony 3.3 #940
@Haehnchen Haehnchen added fixed and removed todo labels Jun 3, 2017
@MetalArend
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants