Deku Nut upgrade fix works retroactively

[JordanLongstaff]

The "Fix Deku Nut upgrade" enhancement previously only worked if it was set before getting the Poacher's Saw; if done after, the upgrade flag is still set erroneously and can only be cleared in the Save Editor. Now, toggling the fix enhancement will automatically reconcile the upgrade flag.

Build Artifacts

• soh-windows.zip
• soh-mac.zip
• soh-linux.zip

[JordanLongstaff]

I'm sure this needs work. Rando especially is likely to be broken by this. So far I've only solved the issue that exists in vanilla.

One question I have is, is there a reason for this option not to be forced on in rando?

[Pepper0ni]

I'd be very suprised if it had any effect on rando after V3. Maybe check the hook and see how it's implemented. I agree that it should be forced on in rando (or more likely, be made irellevent and grayed out).

[JordanLongstaff]

Maybe check the hook and see how it's implemented.

There isn't a hook. I'm pretty sure this fix option predates VB and rando hooks. All it does at present is "If given Poacher's Saw and setting is not turned on, set flag".

I just learned something new, BTW: even in vanilla, Deku Nut capacity isn't unlocked until you acquire your first Deku Nut. ^_^ I'm guessing the same is true for rando, so I just need to make that adjustment.

[Malkierian]

I just learned something new, BTW: even in vanilla, Deku Nut capacity isn't unlocked until you acquire your first Deku Nut. ^_^ I'm guessing the same is true for rando, so I just need to make that adjustment.

Yeah, this is why nut and stick bags were so easy to implement. Thy were just preventing that automatic first capacity give that the game hides like that.

[Pepper0ni]

OK, I looked into the rando situation with deku theater and it looks like it just reacts to the vanilla flag, and this fix seems to have no safeguards to account for rando, because of this I think the best idea is to simply force the fix on in rando and prevent toggling this, as that both prevents the bug from doing something annoying and prevents this code from messing up rando saves.

[aMannus]

I'm okay with the premise of this but it really should live inside a hook instead of the code living inside the checkbox in the ImGui code.

Take a look at #4819 for examples using the recently introduced hooks through ShipInit, that also handles applying hooks when toggling a cvar with a checkbox, so it's the perfect fit.