Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize Flat subexpressions #21

Open
HarrisonGrodin opened this issue Aug 7, 2018 · 0 comments
Open

Normalize Flat subexpressions #21

HarrisonGrodin opened this issue Aug 7, 2018 · 0 comments
Labels
bug Something isn't working
Milestone
0.1

Comments

@HarrisonGrodin
Copy link
Owner

Currently, normalization on flat expressions only attempts to match the pattern to the full expression, not subexpressions. Thus, given the rule f(x) * g(x) => x, the term f(1) * g(1) will return 1, but the term f(1) * g(1) * h()` will not normalize.
@HarrisonGrodin HarrisonGrodin added the bug Something isn't working label Aug 7, 2018
@HarrisonGrodin HarrisonGrodin added this to the 0.1 milestone Aug 7, 2018
HarrisonGrodin added a commit that referenced this issue Aug 8, 2018
@HarrisonGrodin
Add broken test for #21
13f5c69
@HarrisonGrodin HarrisonGrodin mentioned this issue Aug 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.1
Development

No branches or pull requests
1 participant
@HarrisonGrodin