Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like numerous performance issues can be attributed to the costliness of AC pattern matching.
The
match
function is called for every application of a pattern-based rule on every subterm of every intermediate term. Thus, matching clearly must be efficient during normalization - for example, a recent coverage build shows that over the course of the test suite, we:match
method 4 million timesMatch
objectsIn addition to the algorithmic complexity associated with associative and commutative matching, allowing for the storage of multiple matches using nested data structures increases the number of allocations performed. Additionally, the use of this specialized algorithm in such a fundamental procedure severely limits our ability to apply other modern research techniques to Rewrite.
This PR removes AC pattern matching, substituting it for more performant normalization strategies when AC is necessary.