-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Exp rules #80
base: master
Are you sure you want to change the base?
add Exp rules #80
Conversation
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
=========================================
+ Coverage 88.47% 92.78% +4.3%
=========================================
Files 8 8
Lines 269 291 +22
=========================================
+ Hits 238 270 +32
+ Misses 31 21 -10
Continue to review full report at Codecov.
|
it seems the rule of julia> dump(r)
PatternRule
left: Term
ex: Expr
head: Symbol call
args: Array{Any}((2,))
1: exp (function of type typeof(exp))
2: Expr
head: Symbol call
args: Array{Any}((3,))
1: * (function of type typeof(*))
2: Expr
head: Symbol call
args: Array{Any}((3,))
1: * (function of type typeof(*))
2: Int64 2
3: Irrational{:π} π = 3.1415926535897...
3: Complex{Bool}
re: Bool false
im: Bool true
right: Term
ex: Int64 1
ps: Array{Function}((0,)) but after |
I fixed this by defining it as |
however I find this might be conflict with BASIC rules which evals the pi * im expression, is there a way to treat
Irrational
s differently?Update: I changed the
is_constant
and printings forIrrational
, it looks working now! should fix #81