-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto detect window size and etc. #1811
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
dd7fc91
Update FlxText.hx
buckle2000 535f5c8
fixed something
c66c350
fixed something
7257057
revert
c243bbb
Update FlxTilemap.hx
buckle2000 5309f79
Update FlxTilemap.hx
buckle2000 63e0406
Update FlxTilemap.hx
buckle2000 3a6caf0
Update FlxTilemap.hx
buckle2000 bb2d895
Update FlxTilemap.hx
buckle2000 feae523
Auto check window size
3730d00
Merge branch 'dev' of https://github.com/buckle2000/flixel into dev
e365f2a
add a improvement to FlxPoint
d0e5732
Update FlxGame.hx
buckle2000 ea5d7ee
Update FlxPoint.hx
buckle2000 098606e
Update FlxGame.hx
buckle2000 4a1714e
moved FlxVector#scale
7f5c388
fixed scale function of FlxVector
16ae6e4
keep the two functions
4f0c996
Update FlxGame.hx
buckle2000 0c30773
use stage.stageWidth instead
d516806
Merge branch 'dev' of https://github.com/buckle2000/flixel into dev
fa34754
remove inline from FlxVector#scale
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should stick to only
== 0
. Something likenew FlxGame(-10, -50, PlayState)
would result in windowSize x windowHeight, which seems a little weird.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I don't understand what do you mean by
windowSize x windowHeight
.Another reason I can think of is to reserve the negative values for possible more implements in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant windowWidth x windowHeight.
What I meant is that it seems confusing to the reader that random negative values would turn into a
FlxGame
instance which uses the window dimensions, wheareas with0
, you can at least guess that it probably has some special meaning.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the comments, so it is easier to be understood.
Just think if somehow a negative value is passed in,
FlxGame
can deal with it.