Cancel grandchild tweens #2354
Merged
Cancel grandchild tweens #2354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gama11
reviewed
Jul 22, 2021
| @@ -39,16 +39,19 @@ class FlxCameraTest extends FlxTest | |||
| @Test | |||
| function testDefaultCameras():Void | |||
| { | |||
| Assert.areEqual(FlxG.cameras.defaults, FlxCamera.defaultCameras); | |||
| @:privateAccess | |||
There was a problem hiding this comment.
Why start using privateAccess in here?
There was a problem hiding this comment.
to remove the deprecation warnings
There was a problem hiding this comment.
That feels very hacky. I think I'd rather have the deprecation warnings.
There was a problem hiding this comment.
both seem hacky, but sure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tween above can already be cancelled, via:
but because the camera is the actual tween target, it should also be cancelled with:
Whereas
tween(camera.scroll, {y: 500}, 1.0)is not a tween on camera, so it must be cancelled withcancelTweensOf(camera.scroll)orcancelTweensOf(camera, ['scroll.y']).