Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a test file link to each row #222

Merged

Conversation

nissy-dev
Copy link
Contributor

fix #221

To fix #221, I implemented the remoteUrlForTestFiles options. If user set this value, the Details Table shows an icon link to each rows. The link is constructed by joining remoteUrlForTestFiles (ex: https://github.com/Hazyzh/jest-html-reporters/blob/master) and relativePath (ex: /src/untils/index.test.js) for each tests.

@smith558
Copy link

smith558 commented Jun 29, 2022

Could you add an example of the feature to the README as well?

@nissy-dev nissy-dev force-pushed the feat-add-test-link-to-each-table-row branch from 0e52072 to 9d7e2bb Compare June 30, 2022 12:50
@nissy-dev nissy-dev force-pushed the feat-add-test-link-to-each-table-row branch from 9d7e2bb to 56bdd5c Compare June 30, 2022 12:51
@nissy-dev
Copy link
Contributor Author

@smith558 Thank you for comments! I add an example of the feature to the README as well.

I seem that CI faild becaue [email protected] no longer working (see: Borales/actions-yarn#49)
Based on the discussion in the issue, this problem resolved v3.0. Is it better to update actions-yarn to v3.0?

@nissy-dev
Copy link
Contributor Author

nissy-dev commented Jul 2, 2022

@Hazyzh

I seem that CI faild becaue [email protected] no longer working (see: Borales/actions-yarn#49)
Based on the discussion in the issue, this problem resolved v3.0. Is it better to update actions-yarn to v3.0?

On my folk repository, I confirmed the CI passed by upgrading actions-yarn to v3.0! (see: nissy-dev#1) Can you rerun the CI?

@Hazyzh Hazyzh merged commit b139e93 into Hazyzh:master Jul 3, 2022
@Hazyzh
Copy link
Owner

Hazyzh commented Jul 3, 2022

hi @nissy-dev, I am a little busy in recent days, sorry for the late reply. I just release a new version v3.0.10 which includes your commit.

Thanks for your contribution, and help to fix the GitHub action issue. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a link to the test file
3 participants