Add toolbar option to toggle Split Keyboard Setting - Enhancement #1218

[PurplePickleMonster]

Enhancement: #1218

Add toolbar option to toggle Split Keyboard Setting.

Screen_recording_20250103_233551.webm

[Helium314]

Thanks, this looks good.
I'll have a closer look in the next few days.

Is there a technical reason for split and merge being separate key codes, or could it be changed to a toggle?

[PurplePickleMonster]

Thanks, this looks good. I'll have a closer look in the next few days.

Is there a technical reason for split and merge being separate key codes, or could it be changed to a toggle?

Sounds good. Yes I believe this can be a toggle instead. I will look into updating this week.

[Helium314]

Yes I believe this can be a toggle instead

On first glance it looked like it should work, so I wasn't sure why you would take the 2 keycode approach.
But now I see I did the same for one-handed mode, which was done for historic reasons... I guess I'll also change it into a single code later.

[PurplePickleMonster]

MERGE_LAYOUT Keycode removed and SPLIT_LAYOUT is now a toggle of the SplitKeyboardEnabled Setting

[Helium314]

This is not necessary. Currently it does nothing, because DEFAULT is only accessed by index of ID_TO_NAME, and you do not add an entry to ID_TO_NAME.

I recommend to just remove it again and leave KeyboardCodesSet untouched, as it is only used for the "old" label + code style like a|!code/key_action_previous, which only exists for historic reasons (I don't want to break people's layouts by removing it).

[PurplePickleMonster]

Reverted change, KeyboardCodesSet is no longer modified

[Helium314]

The SPLIT_LAYOUT code needs to be added to checkAndConvertCode in KeyCode.kt, so people can define the split key (code) anywhere they want.
Looking at KeyCode.kt I see why you chose the split / merge code approach. I didn't notice they were both in the FlorisBoard codes. But I think a single code is enough.

[Helium314]

Could you also set the activation state of the SPLIT key in ToolbarUtils.createToolbarKey?

[Helium314]

I noticed an issue that makes things a little more complicated: the split button does nothing if the screen width is under 600 dp (as per SettingsValues).
This will certainly be reported as a but, and needs to be addressed.

Currently I see 2 ways:

1. hiding the split button when the width is < 600 dp
   but I fear this will also look like a bug to some users (split button available in toolbar settings, but not on toolbar, and other things with custom split key and device orientation)
2. drop the 600 dp requirement
   this will break things for people who currently have a normal keyboard in portrait orientation, and a split keyboard in landscape. Only solution I see here is to "split the split" into portrait and landscape, and have the toolbar key toggle split for the current orientation.

[PurplePickleMonster]

@Helium314 That was difficult... but it works... 🥴 Toggle now controls split layout only for current orientation. There are now two settings options, one for each orientation.

[Helium314]

Thanks for adding this.

That was difficult...

Sorry, it was not meant to be some sort of time-wasting exercise. I should have mentioned that you can simply ask me if you have some difficulties.

Anyway, could you still adjust the split code a little?
I'd like to handle the display orientation in SettingsValues similar to mOneHandedModeEnabled = Settings.readOneHandedModeEnabled(prefs, mDisplayOrientation == Configuration.ORIENTATION_PORTRAIT), so there is no need to change anything that queries mIsSplitKeyboardEnabled. Well, except for appearance settings of course.

Do you think the settings for mSplitKeyboardSpacerRelativeWidth also need to be split?
I can imagine users might want it to be different, but also I don't use the split keyboard at all. Anyway it's your decision and it can also be added later.

[Helium314]

Math.min(Math.max((displayWidthDp) / 0.15f, 0.15f), 0.35f) is always 0.35 if your display is more than 1 dp wide.
I think the old method should still be used, so users don't have to re-adjust the split width setting.