-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for tasker #290
base: main
Are you sure you want to change the base?
Conversation
Currently, only a single "input text" action.
Could you explain what this is doing? I would really like to avoid additional permissions. Why is a the foreground service permission necessary? It doesn't look like you create a foreground service. |
Will this allow triggering of Tasker tasks via keys / key combinations? |
@Helium314 The guide comes from here - https://tasker.joaoapps.com/pluginslibrary.html @russianspy1234 |
I vote against adding 3rd party stuff in, this is how bloatware and deprecated code is made. |
Tasker isn't just any third party app. Integrating with it opens up so many options it's crazy and it's not much in the way of bloat. It would also pretty much immediately bring the tasker users in as users of this keyboard since I don't think any keyboard app currently has tasker integration |
We can have alternative APIs if we don't want tasker - |
From what I know of tasker, intents would work best since http and webhooks would have more overhead and require more permissions while intents do nothing if tasker (or other apps) aren't directly reacting to them |
Actually I had expected that tasker would work with intents, instead of requiring a library and additional permissions... |
Intents are enough to be able to trigger tasker tasks but I don't think you can allow tasker to change things in openboard without adding that library. Or can you just add receivers without it? |
There are already broadcast receivers in Or is there a reason why it wouldn't work with intents from tasker? |
I'm not too familiar with using receivers but they essentially allow Tasker to trigger what they do. I'm not well versed enough to pull the needed info for Tasker from the example code (though I'll play around and try). The only other app I've used Tasker like that with had the fields needed for Tasker listed in a section. |
You don't need to use a library, just need to define a https://github.com/termux/termux-tasker/blob/master/app/src/main/AndroidManifest.xml https://www.twofortyfouram.com/developer |
The current receiver is protected by a permission, which would then have to be added inside Tasker and all other plugin host apps, which may not be acceptable to their devs. Any sensitive actions shouldn't be allowed without permission/auth protection, but pretty much all plugins, except Termux:Tasker, even with dangerous permissions can be sent intents without any protection in Tasker and related ecosystem, it's a mess. |
What about going the other way? To add/expose broadcasters so that Tasker can react to things that happen in this app? |
You can always send intents to tasker or required packages. For tasker, you can receive them with the |
I would be happy if each key press sent an intent that Tasker could reply to, not sure if that would affect performance though... I personally can't think of anything I would want to change in the keyboard using Tasker, but I'm sure others could. The main thing I want to do is add cut, copy, select all, and paste shortcuts to x,c,a,v long press. Maybe the ability to run some other tasks via holding other keys. |
This permission is only for hiding the keyboard by other apps, and I think requiring every app that sends intents to have this permission is not a good idea. I removed this particular receiver and the permission.
That should be possible, but I don't know whether it will work well. Especially there might be some delay. |
That can be added in this app itself instead of requiring tasker. You can also show an overlay scene from tasker when keyboard is active and do any random actions, tasker has
That too should be added to this app, this app can have some config screen that takes an intent's action, extras, package and class info for a key or key combo and sends an intent when they are pressed. However, sending it for each key press, where user may be pressing multiple keys per second would likely be abusing the intent system and intents are also throttled under heavy system load.
You can add a setting that allows users to define a list of package names that are allowed to do certain action actions in the keyboard, like hide it. The other apps can generate a pending broadcast intent and sent it to your app, and you can verify the package name with https://developer.android.com/reference/android/app/PendingIntent#getCreatorPackage() |
Here's a tasker project that modified text input field with tasker without requiring keyboard support. https://www.reddit.com/r/tasker/comments/l1cmqs/project_share_𝘍𝘰𝘳𝘮𝘢𝘵_𝘵𝘦𝘹𝘵_where_𝗛𝗧𝗠𝗟_or_𝙢𝙖𝙧𝙠𝙙𝙤𝙬𝙣/ |
Please don't. Looks like a perfect way to facilitate a keylogger implementation. With an added benefit of reduced performance and additional bloat. |
Yeah good point. Still, something like a modifier that sends the next key as an intent would be great though |
Hey if you came accros this comments please i need help in termux, how to go about the app and in need of a group that will teach me termux basic command👍 |
I'll convert this into a draft, since this is more a discussion than a PR. I have nothing against a tasker support in general, but
|
This PR aims to add support for tasker for openboard (#273).
Currently, I've implemented a simple action that lets you send text into the keyboard.
I intend to later on add more control and events from the keyboard.