text to be committed is the middle suggestion #672
Conversation
codokie
changed the title
|
Technically it's fine, only some minor naming things. |
| // make sure typed word is shown, so user is able to override incoming autocorrection | ||
| // If there is an incoming autocorrection, make sure typed word is shown, so user is able to override it. | ||
| // Otherwise, if the relevant setting is enabled, show the typed word in the middle. | ||
| val typedIndex = if (hasAutoCorrection) 2 else 1 |
There was a problem hiding this comment.
typedIndex is a confusing name, please be more explicit (e.g. indexOfTypedWord)
| <!-- Option to show the text to be committed as the middle middle suggestion --> | ||
| <string name="center_suggestion_text_to_commit">Center text to commit</string> | ||
| <!-- Description for the center text to commit setting --> | ||
| <string name="center_suggestion_text_to_commit_summary">If enabled, the middle suggestion will show the text to be committed</string> |
There was a problem hiding this comment.
I think it would be good to avoid to avoid "commit" in the name and description (no one used it in the related issue).
Also it's somewhat confusing, as the context of where the text is centered is not clear.
I'm not good at finding short and clear titles and descriptions, not sure how much I can help here...
There was a problem hiding this comment.
I asked in the issue, maybe someone has a good idea. If not we can still change it later (though it would mean unnecessary work for translators)
There was a problem hiding this comment.
Maybe "middle suggestion always used"? Then for the description something like "If enabled, the middle suggestion will display the word selected for completion, whether the typed text was correct or not"? Add a bit more detail for what its doing. Obviously just some ideas
There was a problem hiding this comment.
"Always use middle suggestion" sounds good to me, at least I think this is hardest do mis-interpret.
And as summary something like "On pressing space or punctuation, the middle suggestion will be used". Or maybe "typed" or "entered"?
There was a problem hiding this comment.
Used or entered seem better, given no typing is taking place. Entered leaves less ambiguity, but used might be more clear. Your summary is much clearer than mine in fewer words lol
|
I'm not able to finish this PR right? I was gonna go and add the changes we discussed, but it seems only the original contributor is able to do that? |
|
You could always clone the fork, use their branch, and make a new PR. 😉 They'd still get credit for their commits. |
|
Is that rude lol? I don't really know what the best practices are for contributing |
|
I don't think so, if the original PR stalls, anyone is welcome to pick it up. Again, the OP will still get credit for their commits as a contributor to this repo. 😊 |
|
By clone, did you mean fork? I don't have write permission into the original fork, so I would think I would need to create my own fork and push to that? Sorry for all the questions, appreciate your time. |
|
Yeah sorry, not exactly the right use of terminology. I would fork this repo, but then add codokie's repo as a remote. Then you can check out the branch from the remote and either commit directly to it or make a new branch from it. Then push it to your fork and PR here. Let me know if that helps or not. I can write up some Git commands if that would help more. 😊 |
Fixes #658
After testing it for a while there does not seem to be a need for a separate setting to toggle this functionality.The change has effect only if autocorrect is enabled and it seems very intuitive that the middle suggestion should be the text that will be committed should the space key be pressed.
Nevermind, I may be able to see why some individuals may not be crazy about it. So I've added a setting (off by default) called "Center text to commit".
It is under Suggestions settings and can be activated even if autocorrect is disabled, although it makes more sense to do so when it autocorrect is on.