Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Eastern Mari layout #755

Merged
merged 2 commits into from
May 1, 2024
Merged

Add Eastern Mari layout #755

merged 2 commits into from
May 1, 2024

Conversation

ViZiD
Copy link
Contributor

@ViZiD ViZiD commented Apr 26, 2024

@tenextractor
Copy link
Contributor

tenextractor commented Apr 27, 2024

Hiding the commonly used characters Ҥ Ӧ Ӱ behind popup keys is not a good idea.

I suggest using a similar layout as Chuvash like this:

Ё Ҥ Ӧ Ӱ Ъ - ! ? " /
Й Ц У К Е Н Г Ш Щ З Х
Ф Ы В А П Р О Л Д Ж Э
⬆ Я Ч С М И Т Ь Б Ю ⬅

@ViZiD
Copy link
Contributor Author

ViZiD commented Apr 27, 2024

@tenextractor I did this because i'm used to the Microsoft Swift Keyboard layout, it did exactly that there. Is there any way to keep both layouts?

@ViZiD
Copy link
Contributor Author

ViZiD commented Apr 27, 2024

@tenextractor ok, i make change and this layout look better.

@tenextractor
Copy link
Contributor

@ViZiD you can add them as popup keys under this layout too, so for example you have Ҥ in the top row but also as a pop up key under Н if you're used to typing it that way

@ViZiD
Copy link
Contributor Author

ViZiD commented Apr 27, 2024

@tenextractor It's not such a big problem, thank you. I made the changes you suggested in the first comment, can you review?

@tenextractor
Copy link
Contributor

Looks good, just one small thing, because the top row has the numbers 0-9 as popup keys, it's better to have 10 keys in the top row so it's better to add / or some other commonly used special character to make the top row have 10 keys. Thanks for updating the layout.

@Helium314
Copy link
Owner

Is the language name displayed correctly, or does it just show mhr in either the main settings screen or the language selection screen?

@Helium314
Copy link
Owner

And a small request: could you change the layout name to something like mari.txt? I think there is no other layout that uses both language name and language code in the file name.

@ViZiD
Copy link
Contributor Author

ViZiD commented Apr 30, 2024

@Helium314 Done

@ViZiD
Copy link
Contributor Author

ViZiD commented May 1, 2024

Is the language name displayed correctly, or does it just show mhr in either the main settings screen or the language selection screen?

Yes, in the debug app it is displayed correctly, but unlike the Chuvash language it is somehow named "Марийский" in russian, for example the Chuvash layout is displayed in Chuvash "чӑваш"

@Helium314
Copy link
Owner

Might not be great, but I think it's still acceptable. Maybe the name will be improved in newer Android versions.

@Helium314 Helium314 merged commit 5440a3e into Helium314:main May 1, 2024
1 check passed
@ViZiD ViZiD deleted the mari branch May 2, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants