Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove subpackage tests #115

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Remove subpackage tests #115

merged 3 commits into from
Nov 14, 2024

Conversation

ReubenJ
Copy link
Member

@ReubenJ ReubenJ commented Nov 14, 2024

  • Adds Aqua and JET testing (should catch something like typo in src/Herb.jl  #113 in the future)
  • Runs the notebook-building process when testing the package
  • Moves to the test dependencies to their own test/Project.toml

@ReubenJ ReubenJ self-assigned this Nov 14, 2024
@ReubenJ ReubenJ linked an issue Nov 14, 2024 that may be closed by this pull request
Copy link
Contributor

@pwochner pwochner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ReubenJ
Copy link
Member Author

ReubenJ commented Nov 14, 2024

Looks like the JET tests are dependent on the specific Julia version. Removing them for now.

- Add Aqua tests
- Add tutorial notebook building as a smoke test
@ReubenJ ReubenJ merged commit 0e61730 into master Nov 14, 2024
4 checks passed
@ReubenJ ReubenJ deleted the test/remove-subpackage-tests branch November 14, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on Pkg
2 participants