Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new attempt at clean PSB2 with five base problems #60

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

IssaHanou
Copy link
Member

@IssaHanou IssaHanou commented Oct 9, 2024

Things to check in review:

  • Using IntRule as type for Integer in the grammars.jl (because Integer and Int are both reserved in Julia)
  • The command_while loop implementation in psb2_primitives.jl
  • Are all the required links to the HerbAI framework in place?
  • Is the README clear on how to add new tasks in the benchmark

TODO: testing individual grammar functions and the command_while

Includes problems:

  • Basement
  • Coinsums
  • Fizz Buzz
  • Fuelcost
  • GCD

@IssaHanou IssaHanou changed the title [DRAFT] new attempt at clean PSB2 with basement, coinsums, fizzbuzz, and gcd new attempt at clean PSB2 with basement, coinsums, fizzbuzz, and gcd Oct 9, 2024
@IssaHanou IssaHanou changed the title new attempt at clean PSB2 with basement, coinsums, fizzbuzz, and gcd new attempt at clean PSB2 with five base problems Oct 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 74.03315% with 47 lines in your changes missing coverage. Please review.

Please upload report for BASE (dev@b9afc1d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/data/PSB2_2021/retrieve_all_tasks.jl 0.00% 13 Missing ⚠️
src/data/PSB2_2021/PSB2_2021.jl 7.69% 12 Missing ⚠️
src/data/PSB2_2021/psb2_primitives.jl 63.63% 8 Missing ⚠️
src/data/PSB2_2021/program_examples.jl 78.12% 7 Missing ⚠️
src/utils/benchmarks_io.jl 0.00% 4 Missing ⚠️
src/data/PSB2_2021/base_grammars.jl 0.00% 1 Missing ⚠️
src/data/PSB2_2021/grammar.jl 98.94% 1 Missing ⚠️
src/data/PSB2_2021/problem_grammars.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev      #60   +/-   ##
======================================
  Coverage       ?   55.37%           
======================================
  Files          ?       28           
  Lines          ?      791           
  Branches       ?        0           
======================================
  Hits           ?      438           
  Misses         ?      353           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants