Remove broken references #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cular dependency.
ReubenJ
reviewed
Apr 11, 2024
src/constraint.jl
Outdated
| Represents a constraint for a [`ContextSensitiveGrammar`](@ref). | ||
| Represents a constraint for a `ContextSensitiveGrammar`. |
There was a problem hiding this comment.
I'm not sure why it didn't occur to me earlier, but we could link to AbstractGrammar instead. Was this already discussed before?
There was a problem hiding this comment.
I don't remember this being discussed. I changed it.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
@reftoHerbGrammarwhich doesn't work due to circular dependency: We would need to importHerbGrammarfor reference to work, but we can't do that sinceHerbGrammardepends onHerbCore.Partly addresses #61.