Initial structure for HerbSpecification #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebdumancic
reviewed
Jan 19, 2024
src/problem.jl
Outdated
| struct IOSpecification <: AbstractIOSpecification | ||
|
|
||
| """ | ||
| struct IOSpecification <: AbstractIOSpecification |
There was a problem hiding this comment.
did we say that we drop this or not?
And delegate it to the Problem struct (to have an array of IOExample)?
sebdumancic
reviewed
Jan 19, 2024
src/problem.jl
Outdated
|
|
||
| """ | ||
| struct IOMetricSpecification <: AbstractIOSpecification | ||
| examples::AbstractVector{IOExample} |
There was a problem hiding this comment.
this one is AbstractVector but IOSpecification uses Vector. We should be consistent
sebdumancic
reviewed
Jan 19, 2024
src/problem.jl
Outdated
| struct TraceSpecification | ||
|
|
||
| """ | ||
| struct TraceSpecification <: AbstractSpecification |
There was a problem hiding this comment.
Also delegate to Problem?
Otherwise, we have too many layers of structure to construct which add little information: IOExample -> IOSpecification -> Problem. If we can kick out the middle layer, that would be great
sebdumancic
reviewed
Jan 19, 2024
src/problem.jl
Outdated
| struct AgdaSpecification <: AbstractFormalSpecification | ||
|
|
||
| """ | ||
| struct AgdaSpecification <: AbstractFormalSpecification |
There was a problem hiding this comment.
Agda should be a specialisation of DependentType?
|
Please check again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.