Hidden subviews not taken in account in optimized snapshot type #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cs4alhaider
approved these changes
Sep 7, 2018
|
Any new with this PR? |
|
@ManueGE Can you add a changelog entry for this change? It should go:
Thanks |
ManueGE
force-pushed
the
hidden_subviews_ignored
branch
from
49c6564 to
dd9cd7e
Compare
|
Added the changes to the changelog. |
|
Thanks @ManueGE took me a heck of a long time to review this 😢 |
SD10
approved these changes
Dec 27, 2018
JoeMatt
added a commit
that referenced
this pull request
Oct 29, 2019
- Fix iOS demo app failing and style on iOS 13 - Fix lint warnings and build errors in demo app - Add extra metadata to podspec - Deprecated messages to renamed - Add Joe Mattiello into Podspec authors for publishing - Fix pod lib lint failures - Update Podspec imports to match source imports - Use more minimal import - Remove Swift files from framework bundle products - Remove access modifier warnings (#616) - GitIgnore xcode log files - Docs - Run jazzy against new spec - Docs - Update jazzy config - Bump version to 1.5.0 - Set theme jekyll-theme-midnight - Use custom snapshot for views that implements HeroCustomSnapshotView (#541) - Keep using default navigation animation direction with RTL languages (#520) - Hidden subviews not taken in account in optimized snapshot type (#521) - Update Collection 2.0 (#553) Signed-off-by: Joe Mattiello <[email protected]> # gpg: Signature made Mon Oct 28 21:28:30 2019 EDT # gpg: using RSA key 8D361039DCE5C34A90E4E466A4679EBF9DE83365 # gpg: Good signature from "Joseph Mattiello <[email protected]>" [ultimate] # gpg: aka "Joseph Mattiello <[email protected]>" [ultimate] # gpg: aka "Joseph Mattiello <[email protected]>" [ultimate] # gpg: aka "Joseph Mattiello <[email protected]>" [ultimate] # gpg: aka "Joseph Mattiello (Public Git repo commit identity) <[email protected]>" [ultimate] # Conflicts: # Sources/Extensions/UIView+Hero.swift # Sources/Extensions/UIViewController+Hero.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
.optimizedsnapshot type in aUIImageView, the optimized snapshot is ignored if the image view contains at least one subview. This PR change that behavior slightly: it just takes the subviews into account if they are not hidden. So, image views with subviews where all subviews are hidden can still use the optimized snapshot type.