Merge pull request #280 from HewlettPackard/Linting-fixes

Linting_errors_fixed
HewlettPackard · Nov 2, 2023 · c204701 · c204701
2 parents efc5c25 + 26511c3
commit c204701
Show file tree

Hide file tree

Showing 50 changed files with 417 additions and 421 deletions.
diff --git a/plugins/modules/oneview_appliance_device_snmp_v3_trap_destinations.py b/plugins/modules/oneview_appliance_device_snmp_v3_trap_destinations.py
@@ -76,9 +76,9 @@
     state: present
     name: 172.0.0.1
     data:
-        destinationAddress: "172.0.0.1"
-        port: 162
-        userName: "test1"
+      destinationAddress: "172.0.0.1"
+      port: 162
+      userName: "test1"
   delegate_to: localhost
 
 - name: Update the userId of specified SNMPv3 Trap Destination

diff --git a/plugins/modules/oneview_appliance_device_snmp_v3_users.py b/plugins/modules/oneview_appliance_device_snmp_v3_users.py
@@ -72,24 +72,24 @@
     api_version: 800
     state: present
     data:
-        type: "Users"
-        userName: "testUser"
-        securityLevel: "Authentication"
-        authenticationProtocol: "SHA512"
+      type: "Users"
+      userName: "testUser"
+      securityLevel: "Authentication"
+      authenticationProtocol: "SHA512"
   delegate_to: localhost
 
 - debug:
     var: appliance_device_snmp_v3_users
 
 - name: Set the password of specified SNMPv3 user
   oneview_appliance_device_snmp_v3_users:
-   config: "{{ config }}"
-   state: present
-   name: "testUser"
-   data:
-    userName: "testUser"
-    authenticationPassphrase: "NewPass1234"
-    delegate_to: localhost
+    config: "{{ config }}"
+    state: present
+    name: "testUser"
+    data:
+      userName: "testUser"
+      authenticationPassphrase: "NewPass1234"
+      delegate_to: localhost
 
 - debug:
     var: appliance_device_snmp_v3_users
@@ -102,7 +102,7 @@
     api_version: 800
     state: absent
     data:
-        userName: "testUser"
+      userName: "testUser"
   delegate_to: localhost
 '''
 

diff --git a/plugins/modules/oneview_appliance_network_interface_facts.py b/plugins/modules/oneview_appliance_network_interface_facts.py
@@ -69,14 +69,14 @@
   oneview_appliance_network_interface_facts:
     config: "{{ config }}"
     params:
-       mac_address: "{{ mac_address }}"
+      mac_address: "{{ mac_address }}"
   delegate_to: localhost
 
 - name: Gather facts about the all unconfigured Mac Addresses
   oneview_appliance_network_interface_facts:
     config: "{{ config }}"
     options:
-       - getAllMacAddress
+      - getAllMacAddress
   delegate_to: localhost
 
 - debug: var=appliance_network_interfaces

diff --git a/plugins/modules/oneview_appliance_network_interfaces.py b/plugins/modules/oneview_appliance_network_interfaces.py
@@ -77,8 +77,8 @@
       ipv4Subnet: "{{ ipv4_subnet }}"
       ipv4Gateway: "{{ gateway }}"
       ipv4NameServers:
-         - "{{ dnsServer1 }}"
-         - "{{ dnsServer2 }}"
+        - "{{ dnsServer1 }}"
+        - "{{ dnsServer2 }}"
   delegate_to: localhost
 - debug: var=appliance_network_interfaces
 '''

diff --git a/plugins/modules/oneview_connection_template.py b/plugins/modules/oneview_connection_template.py
@@ -67,12 +67,12 @@
     api_version: 2000
     state: present
     data:
-        name: 'name1304244267-1467656930023'
-        type : "connection-template"
-        bandwidth :
-            maximumBandwidth : 10000
-            typicalBandwidth : 2000
-        newName : "CT-23"
+      name: 'name1304244267-1467656930023'
+      type: "connection-template"
+      bandwidth:
+        maximumBandwidth: 10000
+        typicalBandwidth: 2000
+      newName: "CT-23"
   delegate_to: localhost
 '''
 

diff --git a/plugins/modules/oneview_enclosure.py b/plugins/modules/oneview_enclosure.py
@@ -116,12 +116,12 @@
     api_version: 1600
     state: present
     data:
-      enclosureGroupUri : '{{ enclosure_group_uri }}'
-      hostname : '{{ enclosure_hostname }}'
-      username : '{{ enclosure_username }}'
-      password : '{{ enclosure_password }}'
+      enclosureGroupUri: '{{ enclosure_group_uri }}'
+      hostname: '{{ enclosure_hostname }}'
+      username: '{{ enclosure_username }}'
+      password: '{{ enclosure_password }}'
       name: 'Test-Enclosure'
-      licensingIntent : 'OneView'
+      licensingIntent: 'OneView'
 
 - name: Updates the enclosure to have a name of "Test-Enclosure-Renamed".
   oneview_enclosure:
@@ -132,7 +132,7 @@
     state: present
     data:
       name: 'Test-Enclosure'
-      newName : 'Test-Enclosure-Renamed'
+      newName: 'Test-Enclosure-Renamed'
 
 - name: Reconfigure the enclosure "Test-Enclosure"
   oneview_enclosure:

diff --git a/plugins/modules/oneview_enclosure_group.py b/plugins/modules/oneview_enclosure_group.py
@@ -68,29 +68,29 @@
     api_version: 2000
     state: present
     data:
-        name: "Enclosure Group 1"
-        stackingMode: "Enclosure" # Not supported in V600
-        interconnectBayMappings:
-            - interconnectBay: 1
-            - interconnectBay: 2
-            - interconnectBay: 3
-            - interconnectBay: 4
-            - interconnectBay: 5
-            - interconnectBay: 6
-            - interconnectBay: 7
-            - interconnectBay: 8
+      name: "Enclosure Group 1"
+      stackingMode: "Enclosure" # Not supported in V600
+      interconnectBayMappings:
+        - interconnectBay: 1
+        - interconnectBay: 2
+        - interconnectBay: 3
+        - interconnectBay: 4
+        - interconnectBay: 5
+        - interconnectBay: 6
+        - interconnectBay: 7
+        - interconnectBay: 8
   delegate_to: localhost
 
 - name: Update the Enclosure Group changing the name attribute
   oneview_enclosure_group:
-        hostname: 172.16.101.48
-        username: administrator
-        password: my_password
-        api_version: 2000
-        state: present
-        data:
-            name: "Enclosure Group 1"
-            newName: "Enclosure Group 1 (renamed)"
+    hostname: 172.16.101.48
+    username: administrator
+    password: my_password
+    api_version: 2000
+    state: present
+    data:
+      name: "Enclosure Group 1"
+      newName: "Enclosure Group 1 (renamed)"
   delegate_to: localhost
 
 - name: Ensure that Enclosure Group is absent

diff --git a/plugins/modules/oneview_ethernet_network.py b/plugins/modules/oneview_ethernet_network.py
@@ -84,8 +84,8 @@
       name: 'Test Ethernet Network'
       purpose: Management
       bandwidth:
-          maximumBandwidth: 3000
-          typicalBandwidth: 2000
+        maximumBandwidth: 3000
+        typicalBandwidth: 2000
   delegate_to: localhost
 
 - name: Ensure that the Ethernet Network is present with name 'Renamed Ethernet Network'
@@ -160,7 +160,7 @@
     state: absent
     data:
       networkUris:
-        -  "/rest/ethernet-networks/e2f0031b-52bd-4223-9ac1-d91cb519d548"
+        - "/rest/ethernet-networks/e2f0031b-52bd-4223-9ac1-d91cb519d548"
   delegate_to: localhost
 '''
 

diff --git a/plugins/modules/oneview_fcoe_network.py b/plugins/modules/oneview_fcoe_network.py
@@ -107,7 +107,7 @@
     state: absent
     data:
       networkUris:
-        -  "/rest/fcoe-networks/e2f0031b-52bd-4223-9ac1-d91cb519d548"
+        - "/rest/fcoe-networks/e2f0031b-52bd-4223-9ac1-d91cb519d548"
   delegate_to: localhost
 '''
 

diff --git a/plugins/modules/oneview_hypervisor_cluster_profile.py b/plugins/modules/oneview_hypervisor_cluster_profile.py
@@ -95,7 +95,7 @@
           hypervisorManagerUri: '/rest/hypervisor-managers/ee73af7a-1775-44ba-8a66-d0479ec85678'
         hostprefix: 'Test-cluster-host'
     params:
-      create_vswitch_layout: True
+      create_vswitch_layout: true
 - name: Update the Hypervisor Cluster Profile name to 'hcp Renamed'
   oneview_hypervisor_cluster_profile:
     hostname: 172.16.101.48
@@ -109,7 +109,7 @@
       hypervisorType: 'Vmware'
       hypervisorManagerUri: '/rest/hypervisor-manager/rdy-dfdf12'
     params:
-      force: True
+      force: true
 - name: Ensure that the Hypervisor Cluster Profile is absent
   oneview_hypervisor_cluster_profile:
     hostname: 172.16.101.48

diff --git a/plugins/modules/oneview_hypervisor_cluster_profile_facts.py b/plugins/modules/oneview_hypervisor_cluster_profile_facts.py
@@ -107,9 +107,9 @@
     username: administrator
     password: my_password
     api_version: 1200
-    name : "ClusterProfile-1"
+    name: "ClusterProfile-1"
     options:
-        - compliancePreview
+      - compliancePreview
   delegate_to: localhost
 - debug: var=hypervisor_cluster_profiles
 - debug: var=hypervisor_cluster_profile_compliance_preview

diff --git a/plugins/modules/oneview_id_pools.py b/plugins/modules/oneview_id_pools.py
@@ -68,7 +68,7 @@
     data:
       poolType: '{{ poolType }}'
       rangeUris: '{{ id_pool["rangeUris"] }}'
-      enabled: True
+      enabled: true
   delegate_to: localhost
 
 - name: Allocates one or more IDs from a pool

diff --git a/plugins/modules/oneview_id_pools_ipv4_range_facts.py b/plugins/modules/oneview_id_pools_ipv4_range_facts.py
@@ -82,8 +82,8 @@
   oneview_id_pools_ipv4_range_facts:
     config: "{{ config_file_path }}"
     options:
-        - schema
--  debug: var=id_pools_ipv4_ranges
+      - schema
+- debug: var=id_pools_ipv4_ranges
 
 - name: Gather paginated, filtered and sorted facts about ID Pools IPV4 Ranges
   oneview_id_pools_ipv4_range_facts:

diff --git a/plugins/modules/oneview_interconnect_facts.py b/plugins/modules/oneview_interconnect_facts.py
@@ -108,7 +108,7 @@
     api_version: 1200
     name: '0000A66102, interconnect 2'
     options:
-        - nameServers
+      - nameServers
 
 - debug: var=interconnects
 - debug: var=interconnect_name_servers
@@ -121,7 +121,7 @@
     api_version: 1200
     name: '0000A66102, interconnect 2'
     options:
-        - statistics
+      - statistics
 
 - debug: var=interconnects
 - debug: var=interconnect_statistics
@@ -134,7 +134,7 @@
     api_version: 1200
     name: '0000A66102, interconnect 2'
     options:
-        - portStatistics: 'd3'
+      - portStatistics: 'd3'
 
 - debug: var=interconnects
 - debug: var=interconnect_port_statistics
@@ -147,9 +147,9 @@
     api_version: 1200
     name: 'Enc2, interconnect 2'
     options:
-        - subPortStatistics:
-            portName: 'd4'
-            subportNumber: 1
+      - subPortStatistics:
+          portName: 'd4'
+          subportNumber: 1
 
 - debug: var=interconnects
 - debug: var=interconnect_subport_statistics
@@ -162,7 +162,7 @@
     api_version: 1200
     name: '0000A66102, interconnect 2'
     options:
-        - ports
+      - ports
 
 - debug: var=interconnects
 - debug: var=interconnect_ports
@@ -175,7 +175,7 @@
     api_version: 1200
     name: '0000A66102, interconnect 2'
     options:
-        - port: d1
+      - port: d1
 
 - debug: var=interconnects
 - debug: var=interconnect_port
@@ -188,11 +188,10 @@
     api_version: 1200
     name: '0000A66102, interconnect 2'
     options:
-        - pluggableModuleInformation
+      - pluggableModuleInformation
 
 - debug: var=interconnects
 - debug: var=interconnect_pluggable_module_information
-
 '''
 
 RETURN = '''

diff --git a/plugins/modules/oneview_label_facts.py b/plugins/modules/oneview_label_facts.py
@@ -101,7 +101,7 @@
     password: my_password
     api_version: 2600
     name: "{{ labels[0]['name'] }}"
-    get_resources: True
+    get_resources: true
   delegate_to: localhost
 
 - debug: var=labels