-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed mulitpart sig file upload #171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if not self.current_resource:
"No HotFix file"
elif self.current_resource and file_name in self.current_resource.data.get('signatureFileName'):
"file already present so no point checking other status"
return dict(changed=False, msg=self.MSG_SIG_ALREADY_PRESENT)
elif self.current_resource and self.current_resource.data.get('resourceState') != 'Created' and
file_name not in self.current_resource.data.get('signatureFileName'):
"resourceState not Created and file also not exist in signatureFileName"
self.current_resource = self.resource_client.upload_compsig(
file_path)
return dict(changed=True, msg=self.MSG_ADD_SIG, ansible_facts=dict(compsig=self.current_resource))
else
"Corner case"
return "No upload required"
return dict(changed=True, msg=self.MSG_ADD_SIG, ansible_facts=dict(compsig=self.current_resource)) | ||
elif self.current_resource and self.current_resource.data.get('signatureFileRequired') is True: | ||
|
||
elif self.current_resource and self.current_resource.data.get('resourceState') == 'AddFailed' and\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to different checks to see if file is already present. I mean
if self.current_resource and file_name in self.current_resource.data.get('signatureFileName'):
will not do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok with the change but build is failing
Description
[Fixed mulitpart sig file upload]
Issues Resolved
[#168 ]
Check List
$ ansible-test sanity
).