Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OV8.5_Validation #263

Merged
merged 2 commits into from
Aug 29, 2023
Merged

OV8.5_Validation #263

merged 2 commits into from
Aug 29, 2023

Conversation

akshith-gunasheelan
Copy link
Collaborator

@akshith-gunasheelan akshith-gunasheelan commented Aug 14, 2023 •
edited
Loading

Description

HPE OneView 8.50 with API version 5600 for Ansible Collection

Check List

  • New functionality includes sanity testing.
    • All sanity tests pass. ($ ansible-test sanity).
    • All unit tests pass.
  • New functionality has been documented in the README if applicable.
    • New functionality has been thoroughly documented in the examples (please include helpful comments).

alisha-k-kalladassery
alisha-k-kalladassery reviewed Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@alisha-k-kalladassery alisha-k-kalladassery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change api_version in Readme.

alisha-k-kalladassery
alisha-k-kalladassery reviewed Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@alisha-k-kalladassery alisha-k-kalladassery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are couple of other changes also in readme. Please refer previous validation PR and change accordingly.

@akshith-gunasheelan akshith-gunasheelan merged commit 05ae963 into master Aug 29, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisha-k-kalladassery alisha-k-kalladassery alisha-k-kalladassery left review comments

@nabhajit-ray nabhajit-ray nabhajit-ray approved these changes

@AvijitOS AvijitOS AvijitOS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akshith-gunasheelan @AvijitOS @nabhajit-ray @alisha-k-kalladassery