Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting_errors_fixed #280

Merged
merged 1 commit into from
Nov 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,9 @@
state: present
name: 172.0.0.1
data:
destinationAddress: "172.0.0.1"
port: 162
userName: "test1"
destinationAddress: "172.0.0.1"
port: 162
userName: "test1"
delegate_to: localhost

- name: Update the userId of specified SNMPv3 Trap Destination
Expand Down
24 changes: 12 additions & 12 deletions plugins/modules/oneview_appliance_device_snmp_v3_users.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,24 +72,24 @@
api_version: 800
state: present
data:
type: "Users"
userName: "testUser"
securityLevel: "Authentication"
authenticationProtocol: "SHA512"
type: "Users"
userName: "testUser"
securityLevel: "Authentication"
authenticationProtocol: "SHA512"
delegate_to: localhost

- debug:
var: appliance_device_snmp_v3_users

- name: Set the password of specified SNMPv3 user
oneview_appliance_device_snmp_v3_users:
config: "{{ config }}"
state: present
name: "testUser"
data:
userName: "testUser"
authenticationPassphrase: "NewPass1234"
delegate_to: localhost
config: "{{ config }}"
state: present
name: "testUser"
data:
userName: "testUser"
authenticationPassphrase: "NewPass1234"
delegate_to: localhost

- debug:
var: appliance_device_snmp_v3_users
Expand All @@ -102,7 +102,7 @@
api_version: 800
state: absent
data:
userName: "testUser"
userName: "testUser"
delegate_to: localhost
'''

Expand Down
4 changes: 2 additions & 2 deletions plugins/modules/oneview_appliance_network_interface_facts.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,14 +69,14 @@
oneview_appliance_network_interface_facts:
config: "{{ config }}"
params:
mac_address: "{{ mac_address }}"
mac_address: "{{ mac_address }}"
delegate_to: localhost

- name: Gather facts about the all unconfigured Mac Addresses
oneview_appliance_network_interface_facts:
config: "{{ config }}"
options:
- getAllMacAddress
- getAllMacAddress
delegate_to: localhost

- debug: var=appliance_network_interfaces
Expand Down
4 changes: 2 additions & 2 deletions plugins/modules/oneview_appliance_network_interfaces.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@
ipv4Subnet: "{{ ipv4_subnet }}"
ipv4Gateway: "{{ gateway }}"
ipv4NameServers:
- "{{ dnsServer1 }}"
- "{{ dnsServer2 }}"
- "{{ dnsServer1 }}"
- "{{ dnsServer2 }}"
delegate_to: localhost
- debug: var=appliance_network_interfaces
'''
Expand Down
12 changes: 6 additions & 6 deletions plugins/modules/oneview_connection_template.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,12 @@
api_version: 2000
state: present
data:
name: 'name1304244267-1467656930023'
type : "connection-template"
bandwidth :
maximumBandwidth : 10000
typicalBandwidth : 2000
newName : "CT-23"
name: 'name1304244267-1467656930023'
type: "connection-template"
bandwidth:
maximumBandwidth: 10000
typicalBandwidth: 2000
newName: "CT-23"
delegate_to: localhost
'''

Expand Down
12 changes: 6 additions & 6 deletions plugins/modules/oneview_enclosure.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,12 +116,12 @@
api_version: 1600
state: present
data:
enclosureGroupUri : '{{ enclosure_group_uri }}'
hostname : '{{ enclosure_hostname }}'
username : '{{ enclosure_username }}'
password : '{{ enclosure_password }}'
enclosureGroupUri: '{{ enclosure_group_uri }}'
hostname: '{{ enclosure_hostname }}'
username: '{{ enclosure_username }}'
password: '{{ enclosure_password }}'
name: 'Test-Enclosure'
licensingIntent : 'OneView'
licensingIntent: 'OneView'

- name: Updates the enclosure to have a name of "Test-Enclosure-Renamed".
oneview_enclosure:
Expand All @@ -132,7 +132,7 @@
state: present
data:
name: 'Test-Enclosure'
newName : 'Test-Enclosure-Renamed'
newName: 'Test-Enclosure-Renamed'

- name: Reconfigure the enclosure "Test-Enclosure"
oneview_enclosure:
Expand Down
38 changes: 19 additions & 19 deletions plugins/modules/oneview_enclosure_group.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,29 +68,29 @@
api_version: 2000
state: present
data:
name: "Enclosure Group 1"
stackingMode: "Enclosure" # Not supported in V600
interconnectBayMappings:
- interconnectBay: 1
- interconnectBay: 2
- interconnectBay: 3
- interconnectBay: 4
- interconnectBay: 5
- interconnectBay: 6
- interconnectBay: 7
- interconnectBay: 8
name: "Enclosure Group 1"
stackingMode: "Enclosure" # Not supported in V600
interconnectBayMappings:
- interconnectBay: 1
- interconnectBay: 2
- interconnectBay: 3
- interconnectBay: 4
- interconnectBay: 5
- interconnectBay: 6
- interconnectBay: 7
- interconnectBay: 8
delegate_to: localhost

- name: Update the Enclosure Group changing the name attribute
oneview_enclosure_group:
hostname: 172.16.101.48
username: administrator
password: my_password
api_version: 2000
state: present
data:
name: "Enclosure Group 1"
newName: "Enclosure Group 1 (renamed)"
hostname: 172.16.101.48
username: administrator
password: my_password
api_version: 2000
state: present
data:
name: "Enclosure Group 1"
newName: "Enclosure Group 1 (renamed)"
delegate_to: localhost

- name: Ensure that Enclosure Group is absent
Expand Down
6 changes: 3 additions & 3 deletions plugins/modules/oneview_ethernet_network.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@
name: 'Test Ethernet Network'
purpose: Management
bandwidth:
maximumBandwidth: 3000
typicalBandwidth: 2000
maximumBandwidth: 3000
typicalBandwidth: 2000
delegate_to: localhost

- name: Ensure that the Ethernet Network is present with name 'Renamed Ethernet Network'
Expand Down Expand Up @@ -160,7 +160,7 @@
state: absent
data:
networkUris:
- "/rest/ethernet-networks/e2f0031b-52bd-4223-9ac1-d91cb519d548"
- "/rest/ethernet-networks/e2f0031b-52bd-4223-9ac1-d91cb519d548"
delegate_to: localhost
'''

Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/oneview_fcoe_network.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
state: absent
data:
networkUris:
- "/rest/fcoe-networks/e2f0031b-52bd-4223-9ac1-d91cb519d548"
- "/rest/fcoe-networks/e2f0031b-52bd-4223-9ac1-d91cb519d548"
delegate_to: localhost
'''

Expand Down
4 changes: 2 additions & 2 deletions plugins/modules/oneview_hypervisor_cluster_profile.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
hypervisorManagerUri: '/rest/hypervisor-managers/ee73af7a-1775-44ba-8a66-d0479ec85678'
hostprefix: 'Test-cluster-host'
params:
create_vswitch_layout: True
create_vswitch_layout: true
- name: Update the Hypervisor Cluster Profile name to 'hcp Renamed'
oneview_hypervisor_cluster_profile:
hostname: 172.16.101.48
Expand All @@ -109,7 +109,7 @@
hypervisorType: 'Vmware'
hypervisorManagerUri: '/rest/hypervisor-manager/rdy-dfdf12'
params:
force: True
force: true
- name: Ensure that the Hypervisor Cluster Profile is absent
oneview_hypervisor_cluster_profile:
hostname: 172.16.101.48
Expand Down
4 changes: 2 additions & 2 deletions plugins/modules/oneview_hypervisor_cluster_profile_facts.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,9 @@
username: administrator
password: my_password
api_version: 1200
name : "ClusterProfile-1"
name: "ClusterProfile-1"
options:
- compliancePreview
- compliancePreview
delegate_to: localhost
- debug: var=hypervisor_cluster_profiles
- debug: var=hypervisor_cluster_profile_compliance_preview
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/oneview_id_pools.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
data:
poolType: '{{ poolType }}'
rangeUris: '{{ id_pool["rangeUris"] }}'
enabled: True
enabled: true
delegate_to: localhost

- name: Allocates one or more IDs from a pool
Expand Down
4 changes: 2 additions & 2 deletions plugins/modules/oneview_id_pools_ipv4_range_facts.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@
oneview_id_pools_ipv4_range_facts:
config: "{{ config_file_path }}"
options:
- schema
- debug: var=id_pools_ipv4_ranges
- schema
- debug: var=id_pools_ipv4_ranges

- name: Gather paginated, filtered and sorted facts about ID Pools IPV4 Ranges
oneview_id_pools_ipv4_range_facts:
Expand Down
19 changes: 9 additions & 10 deletions plugins/modules/oneview_interconnect_facts.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@
api_version: 1200
name: '0000A66102, interconnect 2'
options:
- nameServers
- nameServers

- debug: var=interconnects
- debug: var=interconnect_name_servers
Expand All @@ -121,7 +121,7 @@
api_version: 1200
name: '0000A66102, interconnect 2'
options:
- statistics
- statistics

- debug: var=interconnects
- debug: var=interconnect_statistics
Expand All @@ -134,7 +134,7 @@
api_version: 1200
name: '0000A66102, interconnect 2'
options:
- portStatistics: 'd3'
- portStatistics: 'd3'

- debug: var=interconnects
- debug: var=interconnect_port_statistics
Expand All @@ -147,9 +147,9 @@
api_version: 1200
name: 'Enc2, interconnect 2'
options:
- subPortStatistics:
portName: 'd4'
subportNumber: 1
- subPortStatistics:
portName: 'd4'
subportNumber: 1

- debug: var=interconnects
- debug: var=interconnect_subport_statistics
Expand All @@ -162,7 +162,7 @@
api_version: 1200
name: '0000A66102, interconnect 2'
options:
- ports
- ports

- debug: var=interconnects
- debug: var=interconnect_ports
Expand All @@ -175,7 +175,7 @@
api_version: 1200
name: '0000A66102, interconnect 2'
options:
- port: d1
- port: d1

- debug: var=interconnects
- debug: var=interconnect_port
Expand All @@ -188,11 +188,10 @@
api_version: 1200
name: '0000A66102, interconnect 2'
options:
- pluggableModuleInformation
- pluggableModuleInformation

- debug: var=interconnects
- debug: var=interconnect_pluggable_module_information

'''

RETURN = '''
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/oneview_label_facts.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@
password: my_password
api_version: 2600
name: "{{ labels[0]['name'] }}"
get_resources: True
get_resources: true
delegate_to: localhost

- debug: var=labels
Expand Down
Loading
Loading