-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct check-mode support declaration #288
Correct check-mode support declaration #288
Conversation
Signed-off-by: Arthur Simon <[email protected]>
Signed-off-by: Arthur Simon <[email protected]>
0da6ec3
to
6d3983e
Compare
Signed-off-by: Arthur Simon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think more changes are required to support the check_mode functionality. Also we would need few example tasks to execute and check the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks fine as the scope of the PR is check-mode support declaration and not implementation.
4ed3b14
into
HewlettPackard:master
Description
After the changes, the code indicates which module supports check_mode and which does not, like demonstrated in the following Ansible Documentation: https://docs.ansible.com/ansible/latest/dev_guide/developing_program_flow_modules.html#declaring-check-mode-support
Issues Resolved
None
Check List
$ ansible-test sanity
).