Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct check-mode support declaration #288

Merged

Conversation

arth-simon
Copy link
Contributor

@arth-simon arth-simon commented Feb 22, 2024

Description

After the changes, the code indicates which module supports check_mode and which does not, like demonstrated in the following Ansible Documentation: https://docs.ansible.com/ansible/latest/dev_guide/developing_program_flow_modules.html#declaring-check-mode-support

Issues Resolved

None

Check List

  • New functionality includes sanity testing.
    • All sanity tests pass. ($ ansible-test sanity).
    • All unit tests pass.
  • New functionality has been documented in the README if applicable.
    • New functionality has been thoroughly documented in the examples (please include helpful comments).

@arth-simon arth-simon marked this pull request as ready for review February 22, 2024 10:48
akshith-gunasheelan

This comment was marked as resolved.

@akshith-gunasheelan akshith-gunasheelan dismissed their stale review June 6, 2024 12:39

Review in progress

Copy link
Collaborator

@alisha-k-kalladassery alisha-k-kalladassery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think more changes are required to support the check_mode functionality. Also we would need few example tasks to execute and check the same.

Copy link
Collaborator

@akshith-gunasheelan akshith-gunasheelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Collaborator

@alisha-k-kalladassery alisha-k-kalladassery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks fine as the scope of the PR is check-mode support declaration and not implementation.

@alisha-k-kalladassery alisha-k-kalladassery merged commit 4ed3b14 into HewlettPackard:master Jun 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants