Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SCMB module and CLI command #221

Merged
merged 4 commits into from
Apr 18, 2017
Merged

Added SCMB module and CLI command #221

merged 4 commits into from
Apr 18, 2017

Conversation

jsmartt
Copy link
Collaborator

@jsmartt jsmartt commented Mar 29, 2017

Description

Adds a module that makes it easy to connect to the OV SCMB. This does add a dependency on an additional gem, bunny. There's only 1 other dependency in the chain, so it adds 2 total gems to the run-time dependencies.

Side note: I also updated the CHANGELOG headings to be consistent: # for major releases, ## for all other releases, and #### for sub-sections in releases.

Issues Resolved

none

Check List

  • New functionality includes testing.
    • All tests pass ($ rake test).
  • New functionality has been documented in the README if applicable.
    • New functionality has been thoroughly documented in the examples (please include helpful comments).
  • Changes are documented in the CHANGELOG.

@jsmartt
Copy link
Collaborator Author

jsmartt commented Mar 29, 2017

Note: I'm getting a OpenSSL::X509::CertificateError (not enough data) error when I run the CLI on Windows, because of this issue. Windows users can get around this by adding in the :tls_ca_certificates option when creating a connection, but I'd like to avoid Windows users having to be explicit about it. Let's hold up on this PR until we get a reply on that issue.

@jsmartt
Copy link
Collaborator Author

jsmartt commented Apr 3, 2017

Update: I got the change merged in to bunny to fix Windows clients. We're still waiting on a release, but I think it's fine to move on with this PR now; when bunny gets released (2.6.5), it'll fix the issues for Windows. Can someone take a look at this PR and validate it working in your (Linux) environment?

@aalexmonteiro
Copy link
Contributor

@jsmartt

Yeah! I Can. Wait a bit please.

Copy link
Contributor

@aalexmonteiro aalexmonteiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me! I tested and works fine.

@jsmartt
Copy link
Collaborator Author

jsmartt commented Apr 17, 2017

Now that bunny 2.6.5 is out, I think this is ready to be merged in. Any reservations @tmiotto or @fgbulsoni?

Copy link
Contributor

@tmiotto tmiotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 :shipit:

CHANGELOG.md Outdated

#### Bug fixes & Enhancements:
- [#222](https://github.com/HewlettPackard/oneview-sdk-ruby/issues/222) Error listing the OS Deployment Plans from OneView
- Added SCMB module and CLI command
Copy link
Contributor

@fgbulsoni fgbulsoni Apr 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing link for an issue related? Also, since this is something new, maybe add it under new resource/new feature instead of enhancements and bug fixes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fgbulsoni, I added the change under a "New Features" section, but there's no issue to attach it to, so still no link.

@jsmartt jsmartt merged commit 9c8596c into master Apr 18, 2017
@jsmartt jsmartt deleted the scmb_module branch April 18, 2017 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants