-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added SCMB module and CLI command #221
Conversation
Note: I'm getting a |
Update: I got the change merged in to bunny to fix Windows clients. We're still waiting on a release, but I think it's fine to move on with this PR now; when bunny gets released (2.6.5), it'll fix the issues for Windows. Can someone take a look at this PR and validate it working in your (Linux) environment? |
Yeah! I Can. Wait a bit please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me! I tested and works fine.
Now that bunny 2.6.5 is out, I think this is ready to be merged in. Any reservations @tmiotto or @fgbulsoni? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌮
CHANGELOG.md
Outdated
|
||
#### Bug fixes & Enhancements: | ||
- [#222](https://github.com/HewlettPackard/oneview-sdk-ruby/issues/222) Error listing the OS Deployment Plans from OneView | ||
- Added SCMB module and CLI command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing link for an issue related? Also, since this is something new, maybe add it under new resource
/new feature
instead of enhancements and bug fixes
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fgbulsoni, I added the change under a "New Features" section, but there's no issue to attach it to, so still no link.
Description
Adds a module that makes it easy to connect to the OV SCMB. This does add a dependency on an additional gem, bunny. There's only 1 other dependency in the chain, so it adds 2 total gems to the run-time dependencies.
Side note: I also updated the CHANGELOG headings to be consistent:
#
for major releases,##
for all other releases, and####
for sub-sections in releases.Issues Resolved
none
Check List
$ rake test
).